[JIRA] (IDP-2121) Future Proofing the Module Plugin infrastructure for Future SP use

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2121 ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiMDliMTRhM2MyOTQ3NGM2MWI3OTZiYjgxMWZiMjdkYjEiLCJwIjoiaiJ9 )

Re: Future Proofing the Module Plugin infrastructure for Future SP use ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiMDliMTRhM2MyOTQ3NGM2MWI3OTZiYjgxMWZiMjdkYjEiLCJwIjoiaiJ9 )

Its quite fine to have two versions of a plugin both being latest. At step 2 you’d just upgrade to the latest supported by V4 and in step 4 you upgrade to the latest supported by V5. Its also possible (but weird that the V4 compatible version could be a later version than the V5 one - by way of a test Metadatagen is like that right now).

The problem with the rethrow is that we then bake in the concept of an IdP PluginException and a shib-profile PluginException. By not having the rethrow code the IdP PluginException/ModuleExceptions can be removed in V6.

The only reason that these two classes exists is to be a placeholder so that V4 plugins will at least announce themselves in V5. Without that class (IdP PluginException/ModuleException) the plugin doesn’t load because the classloader loading them cannot find that class. and once you are like that you cannot uninstall the old plugin.

( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiMDliMTRhM2MyOTQ3NGM2MWI3OTZiYjgxMWZiMjdkYjEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiMDliMTRhM2MyOTQ3NGM2MWI3OTZiYjgxMWZiMjdkYjEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:956085d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/3582e2f1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-8e422174-3e0a-4802-8ee9-8105ed8fd783
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/3582e2f1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c2ed28d5-bc4e-4c17-b23a-61f968a0a6ec
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/3582e2f1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f361e248-d53b-4734-aa74-299df2fff2f0
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/3582e2f1/attachment-0005.png>