[JIRA] (IDP-2121) Future Proofing the Module Plugin infrastructure for Future SP use

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2121 ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiZmMxM2ZiYzRjNDQyNDVkM2I2NGYxODEwNTYyOTk1ZDciLCJwIjoiaiJ9 )

Re: Future Proofing the Module Plugin infrastructure for Future SP use ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiZmMxM2ZiYzRjNDQyNDVkM2I2NGYxODEwNTYyOTk1ZDciLCJwIjoiaiJ9 )

After a (long) night’s thought I have come to the conclusion that I am overthinking this.

* There is nothing we can do about the ResourceResult so if we want to proceed we have to break that
* The only methods that involve ModuleResource are enable/disable/getResources and

* In this cases that are ‘just’ garnish for the returned value (in a Collection or a Map). As such they do not affect API interoperability until such time as someone calls them)
* The only people who call them (or should call them) are us : in the ModuleManager and the Installer
* The only people who implement them (as per a grep of all our plugins) are inside the base classes in idp-admin-api

So I am going to not care that they are no longer available on IdPModule and fix up our calls.

Anyone else who is calling these methods is doing something weird and should stop or can recompile.

If someone *is* implemententing any of those three methods then we can still call them but we (in our code) need to

* Redeclare the enum and the subinterface (as deprecated)
* Add code at our point of call to convert from Foo<OldTypeInIdpModule> to Foo<NewTypeInModule>.
* But we don’t need to do that until someone tells us they have a problem because a million installed users which they cannot upgrade and we can slipstream this in in a patch under the “We can change the API to fix bugs” rule.

( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiZmMxM2ZiYzRjNDQyNDVkM2I2NGYxODEwNTYyOTk1ZDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiZmMxM2ZiYzRjNDQyNDVkM2I2NGYxODEwNTYyOTk1ZDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:3b7cdab )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/5c388794/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-b15ecdfc-d586-4c0f-813c-04f7c7546140
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/5c388794/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-cd76db0f-1f7a-45a1-83fc-fcd90fa95eaa
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/5c388794/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6235ca19-317f-4eaf-b52b-55920dab333e
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/5c388794/attachment-0005.png>