[JIRA] (IDP-2121) Future Proofing the Module Plugin infrastructure for Future SP use
Rod Widdowson (Jira)
jira at shibboleth.atlassian.net
Mon Jun 5 16:46:21 UTC 2023
Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2121 ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiZjI4ZTI5MDhjNTk4NGM1ZjlhNzQ5YjhjZjA1ODRkZjYiLCJwIjoiaiJ9 )
Re: Future Proofing the Module Plugin infrastructure for Future SP use ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiZjI4ZTI5MDhjNTk4NGM1ZjlhNzQ5YjhjZjA1ODRkZjYiLCJwIjoiaiJ9 )
This becomes incredibly complicated because the IdPModule is implemented in terms or an enum which it defines (which I could suck up) and an interface which it defines.
The base clas implements the interface.
We get to completely change the API and it refer to different interfaces or we start to drown in parallel extends and supers. where by
* Module defines interface ModuleResaource
* Abstract module defined class BasicModuleResource
But that means that
* IdP Module has to define an interface ModuleResource extends Module.ModuleResource
* AbstractIdPModule has to define class BasicModuleResource extends Module.BasicModuleResource implement ModuleResource
* And of course the base class/module start doing the <T extends foo> thing (or do I mean <T super foo>
And then some of the parameterization on the base classes gets funky.
My head is spinning so I’m walking away and will either poke at it some more or start again from scratch tomorrow.
( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiZjI4ZTI5MDhjNTk4NGM1ZjlhNzQ5YjhjZjA1ODRkZjYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiZjI4ZTI5MDhjNTk4NGM1ZjlhNzQ5YjhjZjA1ODRkZjYiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:4a1ccf9 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230605/a9fd71fa/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e31640d3-41a0-48fd-83fd-685daae3ad4b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230605/a9fd71fa/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-969d5416-dac6-4521-be06-9c839133813a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230605/a9fd71fa/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-352c5c29-58de-41e4-9fcd-594657c8f9cb
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230605/a9fd71fa/attachment-0005.png>
More information about the commits
mailing list