[JIRA] (JMVN-45) Investigate building a parent pom with the minimum subset of JPAR/
Rod Widdowson (Jira)
jira at shibboleth.atlassian.net
Tue Jan 10 16:09:26 UTC 2023
Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JMVN-45 ( https://shibboleth.atlassian.net/browse/JMVN-45?atlOrigin=eyJpIjoiNjdkYzc4ZmJiMTk5NDVmYmFmOTA3NzBlMzRhYTg2YjgiLCJwIjoiaiJ9 )
Re: Investigate building a parent pom with the minimum subset of JPAR/ ( https://shibboleth.atlassian.net/browse/JMVN-45?atlOrigin=eyJpIjoiNjdkYzc4ZmJiMTk5NDVmYmFmOTA3NzBlMzRhYTg2YjgiLCJwIjoiaiJ9 )
Adding a parent pom into a new subdirectory of the enforcer works (even if that's a wee bit weird).
The CI jobs would need some attention to
* Add building the parent (ahead of) building the enforcer
* Add a build of the data as a dependency of the enforcer.
Because of the slight weirdness inherent in having the parent in a subdirectory I’m going to hold off pushing this until tomorrow to allow others to provide feedback.
For Instance
It would be quite possible (for instance) to put the parent into the top level and move the enforcer into a child directory and indeed have the child build from the parent. Long term this might make more sense from an architectural POV and comes with ‘just’ the one off cost of moving everything about.
But…
If we made the child build from the parent then it would then make sense to move their versions forward in lock step. I am less comfortable with that - so I think not having the enforcer as a specific child of the parent make more sense. Which then throws the “Where should the parent live” question back up in the air.
Ugh
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) your input encouraged (and indeed anyone else who is listening should chime in)
( https://shibboleth.atlassian.net/browse/JMVN-45#add-comment?atlOrigin=eyJpIjoiNjdkYzc4ZmJiMTk5NDVmYmFmOTA3NzBlMzRhYTg2YjgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JMVN-45#add-comment?atlOrigin=eyJpIjoiNjdkYzc4ZmJiMTk5NDVmYmFmOTA3NzBlMzRhYTg2YjgiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100213- sha1:cca7326 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230110/71762bd4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6d8d1a23-7c3e-4e24-adb3-18d97b9c0051
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230110/71762bd4/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e70c1159-f550-4be6-8575-71187679298e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230110/71762bd4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c97538b7-de1d-4779-92c4-8dfb7cb30fac
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230110/71762bd4/attachment-0005.png>
More information about the commits
mailing list