[JIRA] (IDP-2069) Null Handling Task

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Wed Feb 8 14:13:36 UTC 2023


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2069 ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiNjZjMmQ4NDY5MjUzNGIyZmI5ZmFiZTA3N2QyN2I3NzgiLCJwIjoiaiJ9 )

Re: Null Handling Task ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiNjZjMmQ4NDY5MjUzNGIyZmI5ZmFiZTA3N2QyN2I3NzgiLCJwIjoiaiJ9 )

Note, in general I add asserts if the non-nullness can be established by dynamics we understand - examples being

* In doExecute() of an Action. We often rely on something being non-null that was checked for being null in doPreExecute()
* @NonNullAfterInit (If feasible I’ll create a new getter that checks component state)

If in doubt I add a Constraint.isNotNull

( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiNjZjMmQ4NDY5MjUzNGIyZmI5ZmFiZTA3N2QyN2I3NzgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiNjZjMmQ4NDY5MjUzNGIyZmI5ZmFiZTA3N2QyN2I3NzgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:6795dbd )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230208/f82f4b6a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9b21cd7f-cb9c-4880-9649-c0123eb9eccf
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230208/f82f4b6a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3bd60372-f77d-43fa-8142-2ac0faa6d369
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230208/f82f4b6a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-025ccd28-c544-4456-af09-a126ef713ba0
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230208/f82f4b6a/attachment-0005.png>


More information about the commits mailing list