[JIRA] (IDP-2069) Null Handling Task

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2069 ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiOGFiZWZjOTYxYzZkNGJkMjliMmFiZDk2OGU4M2RhNmMiLCJwIjoiaiJ9 )

Re: Null Handling Task ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiOGFiZWZjOTYxYzZkNGJkMjliMmFiZDk2OGU4M2RhNmMiLCJwIjoiaiJ9 )

--------
Oddities
--------

As I trawl over the code I’m noticing some oddness. Rather than get distracted I’ll note them in in this comment

net.shibboleth.idp.cas.service.impl.ServiceEntityDescriptor (Constructor)
-------------------------------------------------------------------------

if (StringSupport.trimOrNull(service.getGroup()) != null) {
   getObjectMetadata().put(new EntityGroupName(service.getGroup()));
}

So we check again the trimmed value but set the non trimmed value. This might make sense

( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiOGFiZWZjOTYxYzZkNGJkMjliMmFiZDk2OGU4M2RhNmMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiOGFiZWZjOTYxYzZkNGJkMjliMmFiZDk2OGU4M2RhNmMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:c33f0bb )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/e441d0df/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-730dd9ec-7ff2-4192-a3b9-0364c351dcf1
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/e441d0df/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-511405da-5e60-43fa-9221-0fabcc7ffcf7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/e441d0df/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b9875140-26e2-4cbc-8c85-ba4dfc6f9a7a
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230207/e441d0df/attachment-0005.png>