[JIRA] (JCOMOIDC-48) Move OIDC.SSO profile bean to commons
Philip Smart (Jira)
jira at shibboleth.atlassian.net
Thu Feb 2 14:04:47 UTC 2023
Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-48 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-48?atlOrigin=eyJpIjoiZjAyMzE4MDE0NGUxNDljYjgxZjJhNzE4MTc3NjhjYzkiLCJwIjoiaiJ9 )
Re: Move OIDC.SSO profile bean to commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-48?atlOrigin=eyJpIjoiZjAyMzE4MDE0NGUxNDljYjgxZjJhNzE4MTc3NjhjYzkiLCJwIjoiaiJ9 )
The only remaining issue with the OIDC.SSO bean is the use of the DefaultJWTClaimsValidator bean as the claims validator. The RP does not supply that, so the config will not load without the OP. I propose using the getBean syntax for this, such that it could be null if not supplied.
Obviously, we need to check the OP does not just ignore JWT validation if the bean is null (although once the OP is installed it should pick it up).
( https://shibboleth.atlassian.net/browse/JCOMOIDC-48#add-comment?atlOrigin=eyJpIjoiZjAyMzE4MDE0NGUxNDljYjgxZjJhNzE4MTc3NjhjYzkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-48#add-comment?atlOrigin=eyJpIjoiZjAyMzE4MDE0NGUxNDljYjgxZjJhNzE4MTc3NjhjYzkiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fcee39f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/065eb194/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-55cf80b0-24a6-48a3-941c-d5bd659ea7a2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/065eb194/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5664dc7a-0f5b-4d46-a54b-017c90d425f9
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/065eb194/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-281b5a3c-e57c-4aec-84ee-44e7da21c3d7
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230202/065eb194/attachment-0005.png>
More information about the commits
mailing list