[JIRA] (MDA-278) Investigate performance of EmptyContainerStrippingStage

Ian Young (Jira) jira at shibboleth.atlassian.net
Fri Apr 14 13:47:05 UTC 2023


Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-278 ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYWI5ZjAyOTBkZWY1NDE2N2JmYjU1M2VmNzc4ZDcyYzgiLCJwIjoiaiJ9 )

Re: Investigate performance of EmptyContainerStrippingStage ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYWI5ZjAyOTBkZWY1NDE2N2JmYjU1M2VmNzc4ZDcyYzgiLCJwIjoiaiJ9 )

Checked the rest of the codebase, and this is the only place where there’s a NodeList which is being used on a document that changes underneath it. There’s another use of NodeList in ElementStrippingStage but that actually does copy the located elements into a separate list before doing any work, so it won’t run into this issue.

( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYWI5ZjAyOTBkZWY1NDE2N2JmYjU1M2VmNzc4ZDcyYzgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYWI5ZjAyOTBkZWY1NDE2N2JmYjU1M2VmNzc4ZDcyYzgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:8830b7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/737473f4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4682b5aa-038e-4051-8cfc-44ae72765b05
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/737473f4/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c562da82-f8c3-43e1-bf86-3595c124a67b
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/737473f4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a794bf65-693f-499d-adbf-9e2942d5a8ff
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/737473f4/attachment-0005.png>


More information about the commits mailing list