[JIRA] (MDA-278) Investigate performance of EmptyContainerStrippingStage

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-278 ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYTZiNmZkM2QwOTdkNDZiNzgyZGRkYWRkZDI5MTFmNWUiLCJwIjoiaiJ9 )

Re: Investigate performance of EmptyContainerStrippingStage ( https://shibboleth.atlassian.net/browse/MDA-278?atlOrigin=eyJpIjoiYTZiNmZkM2QwOTdkNDZiNzgyZGRkYWRkZDI5MTFmNWUiLCJwIjoiaiJ9 )

I speculate that this is because of this note in the NodeList API documentation:

> NodeList objects in the DOM are live.

It seems possible that this means that the NodeList implementation recomputes the list if, on access, they detect that the DOM document has changed.

If so, the solution to this would be to iterate over the NodeList just to determine which elements should be removed and collect a list of those; then, iterate over that second list to perform the removals without accessing the NodeList.

( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYTZiNmZkM2QwOTdkNDZiNzgyZGRkYWRkZDI5MTFmNWUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-278#add-comment?atlOrigin=eyJpIjoiYTZiNmZkM2QwOTdkNDZiNzgyZGRkYWRkZDI5MTFmNWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:8830b7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/5e2dd398/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9399fe6c-fb01-478b-a040-18c4558e43c8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/5e2dd398/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e8439ab5-fae6-4d71-8707-73097c7bf08c
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/5e2dd398/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-627e34d5-ee5d-47fd-b6b6-3dfa30d8479a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230414/5e2dd398/attachment-0005.png>