[JIRA] (MDA-284) Convert to static loggers while addressing their nullability
Ian Young (Jira)
jira at shibboleth.atlassian.net
Sat Apr 1 09:57:38 UTC 2023
Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue
Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/MDA-284?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 ) MDA-284 ( https://shibboleth.atlassian.net/browse/MDA-284?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 ) Convert to static loggers while addressing their nullability ( https://shibboleth.atlassian.net/browse/MDA-284?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 )
Issue Type: Improvement Affects Versions: 0.9.2 Assignee: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Created: 01/Apr/23 5:57 AM Fix Versions: 0.10.0 Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )
I’ll be touching all logger acquisition in the project to resolve the nullability warnings around the SLF4J API anyway (by using our new wrapper class). While doing that, it makes sense to convert the logger fields to static (where they are not already) so that the search for the logger is only performed once per class rather than once per instance.
( https://shibboleth.atlassian.net/browse/MDA-284#add-comment?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-284#add-comment?atlOrigin=eyJpIjoiN2ZjODEyNmNhNWIwNDZlMzg4NGM3Mjk5NDQ0OTEzNjciLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:57c27f3 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230401/12bd8f77/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-dc73adc8-41fc-48fe-8802-111174de23f9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230401/12bd8f77/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6fd21cb4-6a51-4e0e-a3ed-6e6d7e8971c1
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230401/12bd8f77/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-965d9d05-d2d3-40aa-8506-708fe37b05a5
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230401/12bd8f77/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-dfc0b8f0-8fe8-4252-bc6e-58365b8f4b00
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230401/12bd8f77/attachment-0007.png>
More information about the commits
mailing list