[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiYmVjZTg0ZTY3OGZlNDI3ZmFjZDI2MzA0NDdjZmFjOWIiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiYmVjZTg0ZTY3OGZlNDI3ZmFjZDI2MzA0NDdjZmFjOWIiLCJwIjoiaiJ9 )

I've done the less radical parts of the rework -

* Make sure that everywhere we can we are using the autoclose
* Force the SpringReloadableService to use our base class.

The (slightly) more radical change is next which is to (try to) remove pin and unpin from the ServicableComponent (since that is an implementation detail - all that is needed is for the service to return a component which can be closed.

I’ll prepare that tonight but probably hold on to in until tomorrow.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiYmVjZTg0ZTY3OGZlNDI3ZmFjZDI2MzA0NDdjZmFjOWIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiYmVjZTg0ZTY3OGZlNDI3ZmFjZDI2MzA0NDdjZmFjOWIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:ee9e30a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220929/29a1e65b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3df1786e-7b66-4676-9f90-22795b306b5f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220929/29a1e65b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-30233407-11e0-4e66-b53c-6b4489d049a0
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220929/29a1e65b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-eeb6b610-a8a1-409c-9f32-610130f14c7f
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220929/29a1e65b/attachment-0005.png>