[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiMTU0MTA3OWE2MzVhNDc0Mzg5NjBmMTJmOWQwNDVlMzQiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiMTU0MTA3OWE2MzVhNDc0Mzg5NjBmMTJmOWQwNDVlMzQiLCJwIjoiaiJ9 )

What we have is OK but I think we can be a bit more radical in V5

* remove pin and unpin from the {{ServiceableComponent}}interface, but leave it in the base class
* Recast our reloadable spring service to use the base class
* And hence the strategies used to populate them (strictyly not needed, but makes things cleaner)

But this gets delicate.

The first thing to do is to remove all out explicit calls to unpinComponent and make then use AutoCloseable.

Then we can probably remove that method from the interface

And then from the classes.

That might leave enough clarity to see about pinComponent (which by then should only be called in the base class and the spring reloadable class.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiMTU0MTA3OWE2MzVhNDc0Mzg5NjBmMTJmOWQwNDVlMzQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiMTU0MTA3OWE2MzVhNDc0Mzg5NjBmMTJmOWQwNDVlMzQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:ee9e30a )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220928/4eee9ecf/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6a3759bc-4352-4979-9ae7-2bb4471d3a3f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220928/4eee9ecf/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c8edbfed-d0e8-44dc-9f80-b9b7777d60a2
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220928/4eee9ecf/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6ac7a58e-53fc-452b-8800-89bdd61589f0
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220928/4eee9ecf/attachment-0005.png>