[JIRA] (MDA-231) Add stage to validate selected DOM attributes as strings

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-231 ( https://shibboleth.atlassian.net/browse/MDA-231?atlOrigin=eyJpIjoiZThhNzc2Mjg4ZjhkNGJjODllODYzYTg1NmRlYzc2ZGEiLCJwIjoiaiJ9 )

Re: Add stage to validate selected DOM attributes as strings ( https://shibboleth.atlassian.net/browse/MDA-231?atlOrigin=eyJpIjoiZThhNzc2Mjg4ZjhkNGJjODllODYzYTg1NmRlYzc2ZGEiLCJwIjoiaiJ9 )

This should appear like the StringElementValidationStage but with a single (nominal) additional property to specify the set of attributes to be tested. In practice, that probably needs one getter but four setters:

* Collection<QName> is the canonical form
* QName for the common case of a single attribute
* Collection<String> for the almost universal case of a set of attributes without namespaces
* String for the common case of a single attribute

Internally, this is probably an unmodifiable private final Set<QName>.

The DOM traversal would be the same as for StringElementValidationStage , which is to say visiting each element named by the elements collection, then working through all of the attributes on visited elements and processing each one which matches any of the indicated attributes.

It might be possible to write this most simply as a subclass of AbstractElementValidationStage which doesn’t initially convert the values to strings but instead passes them as Element}}s. It may be worth having an intermediate {{AbstractAttributeValidationStage in that hierarchy.

It’s probably not worth dividing the hierarchy further up, as it would lead to an awful lot of duplication.

( https://shibboleth.atlassian.net/browse/MDA-231#add-comment?atlOrigin=eyJpIjoiZThhNzc2Mjg4ZjhkNGJjODllODYzYTg1NmRlYzc2ZGEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-231#add-comment?atlOrigin=eyJpIjoiZThhNzc2Mjg4ZjhkNGJjODllODYzYTg1NmRlYzc2ZGEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100209- sha1:597f6a7 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221018/aee46e11/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-49871c89-670f-4bf5-a5f2-ca66e642c008
Type: image/png
Size: 341 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221018/aee46e11/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f77e7c53-43a2-4aa2-9088-e78fc2ee375c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221018/aee46e11/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e31a24d5-83f7-4372-bedf-ddb68fd86bfb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221018/aee46e11/attachment-0005.png>