[JIRA] (IDP-2015) Review web.xml for improvements via code or annotations

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2015 ( https://shibboleth.atlassian.net/browse/IDP-2015?atlOrigin=eyJpIjoiNGM4ZmQ3MDgzZDI2NDM5MDhlNWQ2OTExZGU2OTlmY2UiLCJwIjoiaiJ9 )

Re: Review web.xml for improvements via code or annotations ( https://shibboleth.atlassian.net/browse/IDP-2015?atlOrigin=eyJpIjoiNGM4ZmQ3MDgzZDI2NDM5MDhlNWQ2OTExZGU2OTlmY2UiLCJwIjoiaiJ9 )

There are 3 initializers now:

* Spring root context parameters
* Servlets
* Filters

Filter registration is enabled by default and turned off in the testbed web.xml with an init-param. That’s not a normal need, it’s specialized to the testbed inside-out classpath problem.

Servlet registration is handled by turning on each servlet with an init-parameter and this is working so far for the IdP dispatcher and the metadata JSP. Legacy web.xml’s won’t have these params set so the old declarations will be used instead of the initializer’s work.

Spring context params are set with a third class that only sets them if they’re not set already, so will defer to legacy content.

TBD are the RemoteUser and X.509 authn servlets. They really should have been MVC controllers like the others, but that was my early design error. To avoid them changing locations, we have to maintain that, so this is harder because they also rely on various servlet parameters today for configuration.

I think we want to migrate that to Spring in a compatible way, so I think we need to conditionally (off by default) install them via delegating to a Spring bean version of these classes that will be lazy-init. Spring does not provide a delegating servlet proxy a la their filter class, but we should be able to write one, I hope…

( https://shibboleth.atlassian.net/browse/IDP-2015#add-comment?atlOrigin=eyJpIjoiNGM4ZmQ3MDgzZDI2NDM5MDhlNWQ2OTExZGU2OTlmY2UiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2015#add-comment?atlOrigin=eyJpIjoiNGM4ZmQ3MDgzZDI2NDM5MDhlNWQ2OTExZGU2OTlmY2UiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100207- sha1:bddf6e1 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221003/aa911530/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-37861eb8-2fce-455f-9c89-e05d5f5a455d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221003/aa911530/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-26d7ff30-0a1d-475d-916f-56913505f9e4
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221003/aa911530/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-0f7696d5-6cdf-40e0-9740-f4295ecd2618
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221003/aa911530/attachment-0005.png>