[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiOWMxZGNjYWNjMTVlNDdkYTg1NDQ1NGU0YjYyYzVjYjIiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiOWMxZGNjYWNjMTVlNDdkYTg1NDQ1NGU0YjYyYzVjYjIiLCJwIjoiaiJ9 )

I believe SpringServiceableComponent’s base class already checks for a null context, that was the bug I noticed when it wasn’t setting the context after I removed the doInit override from that class since it hadn’t been calling the base class. The setter I suspect is null because of Spring’s unfortunately nullable ApplicationContextAware setter.

The reason I didn’t log anything on those exceptions was because IIRC (at least with the gauge set), there’s a race condition during startup that causes it to be null for a while and if the service fails, and logging every call there I think would be very loud if it’s unset. I didn’t actually try that. Mostly I just assumed we wanted to do the same thing in the code as before.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiOWMxZGNjYWNjMTVlNDdkYTg1NDQ1NGU0YjYyYzVjYjIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiOWMxZGNjYWNjMTVlNDdkYTg1NDQ1NGU0YjYyYzVjYjIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/80bf2215/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-91f5eab3-8504-444c-9797-e09b6766db8f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/80bf2215/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-53c5d7ae-dd80-4d3b-bae5-d9ff55d78be3
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/80bf2215/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5befdc8e-6951-4345-be77-d306f6beab27
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/80bf2215/attachment-0005.png>