[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiNzE0MjA4YzA0NWI4NGIxZGJmOGFhOTYzOTA5OTQzZTUiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiNzE0MjA4YzA0NWI4NGIxZGJmOGFhOTYzOTA5OTQzZTUiLCJwIjoiaiJ9 )

I am loving the simplification we have finally got to in this handling. I am a @nonull convert. The code is just so much nicer (and I don’t even want to think what it looks like compared to V4)

I add some more comments to a method I had to look at some more and pushed that and I just have three nits:

* One of the bugs you fixed was that I wasn’t injecting the applicationContext into the SpringServiceableComponent , which would have led to a leakage of transcoders in service. I was wondering whether we should make the setter take a @nonull and check for non null ness in the doInitialize() - or move that into the constructor and make it @nonnul.
Note that the field and the getter have to remain nullable because that is the signal that we have been unloaded.
* In AttributeResolveGuageSet and AbstractAttributeDisplayFunction we have removed lots of “checking for null and doing nothing” with a “catch and do nothing”. I accept that this is functionally identical but it wouldn't hurt to log the exception and move on, (like we do in the AttributeNodeMappingProcessor ) would it?

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiNzE0MjA4YzA0NWI4NGIxZGJmOGFhOTYzOTA5OTQzZTUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiNzE0MjA4YzA0NWI4NGIxZGJmOGFhOTYzOTA5OTQzZTUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/0c4ee885/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a89a36d0-ca20-4444-844c-5134e8ca5660
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/0c4ee885/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4710dd15-935c-45ea-b410-c596c5a5688e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/0c4ee885/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-0c51b854-31ad-4124-b004-9d911906cf6b
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221129/0c4ee885/attachment-0005.png>