[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Mon Nov 28 17:54:13 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZGZkNThlYTRhNzMxNDFiYmFlNzBmMTY2NzlmOTFkNGEiLCJwIjoiaiJ9 )
Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZGZkNThlYTRhNzMxNDFiYmFlNzBmMTY2NzlmOTFkNGEiLCJwIjoiaiJ9 )
I think that the extra 2 (and they are identical) AccessControlService wrappers are some sort of mistake by me, they’re being used to wrap the underlying ACS implementation class in a component that does nothing. I think that’s likely me failing to understand all this originally. The fix should be to remove the wrapper, change the class it’s searching for, and delete the 2 classes.
The 3rd class is the service-hiding wrapper I was thinking of, the DelegatingAccessControlManager.
( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZGZkNThlYTRhNzMxNDFiYmFlNzBmMTY2NzlmOTFkNGEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZGZkNThlYTRhNzMxNDFiYmFlNzBmMTY2NzlmOTFkNGEiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/3aab5fa9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4faa9ee3-7bd0-43ae-9add-7d80c0fe47fa
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/3aab5fa9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-20561359-ce13-42f3-9fed-00277564c980
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/3aab5fa9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-4aa8a05b-0e01-4508-9459-3a17ba4b0879
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/3aab5fa9/attachment-0005.png>
More information about the commits
mailing list