[JIRA] (JSSH-5) ServiceableComponent should implement AutoClose

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-5 ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZWMxOTliMTIyYzc1NGM1OGFiMGNiOWI1MTg3OWY1YzMiLCJwIjoiaiJ9 )

Re: ServiceableComponent should implement AutoClose ( https://shibboleth.atlassian.net/browse/JSSH-5?atlOrigin=eyJpIjoiZWMxOTliMTIyYzc1NGM1OGFiMGNiOWI1MTg3OWY1YzMiLCJwIjoiaiJ9 )

Some anomalies with how the various layers initialize needs to be cleaned up, and a bug or two around the use of the new Spring wrapper were also found.

In fixing those, I’m going to make a change to convert the getServiceableComponent API to non-null and have it raise a ServiceException. That aligns to the existing behavior of most, but not all, of the strategy functions, which I think we should also lock down with an interface that stipulates a similar contract.

This is going to break some Java code, but is in line with our general plan to tighten up these cases. Nothing useful can be done with a null return value, so it’s just a lot of extra checking by callers.

( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZWMxOTliMTIyYzc1NGM1OGFiMGNiOWI1MTg3OWY1YzMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-5#add-comment?atlOrigin=eyJpIjoiZWMxOTliMTIyYzc1NGM1OGFiMGNiOWI1MTg3OWY1YzMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/67c2e6eb/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-e3a0066d-e5a0-499d-b0ee-27ca2464a15c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/67c2e6eb/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-58efba0a-bb93-4a59-a63f-c2bede5ef322
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/67c2e6eb/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-ba2867ea-068f-4d42-8a83-8238a178f116
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221128/67c2e6eb/attachment-0005.png>