[JIRA] (IDP-2035) LDAP connection pools are not freeing connections when shut down

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2035 ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiNzUwNDBiYzgxYzFjNDA5M2JmMGRlNDk0MGQxNGRlYzYiLCJwIjoiaiJ9 )

Re: LDAP connection pools are not freeing connections when shut down ( https://shibboleth.atlassian.net/browse/IDP-2035?atlOrigin=eyJpIjoiNzUwNDBiYzgxYzFjNDA5M2JmMGRlNDk0MGQxNGRlYzYiLCJwIjoiaiJ9 )

I’m still mid-cleanup, but that particular case I removed precisely because it wasn’t in fact being used. If you actually let Spring init those objects, they’d break the code in the connector because it was calling a setter on the validator to pass in the fail fast flag.

Likewise, the validator wasn’t actually enforcing component initializatiom before use.

So, it’s not really right now, but it wasn’t right before either. I think if we fix the interface we can put the component layer back into it. V4…I dunno, I think it’s no t easily fixable there.

( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiNzUwNDBiYzgxYzFjNDA5M2JmMGRlNDk0MGQxNGRlYzYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2035#add-comment?atlOrigin=eyJpIjoiNzUwNDBiYzgxYzFjNDA5M2JmMGRlNDk0MGQxNGRlYzYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:9b34d7c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d11f0410/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0a0afaf4-c720-40f6-9913-8d72cc3e7bd5
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d11f0410/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c92f4486-378c-4aff-baea-510bd4977356
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d11f0410/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-20a66a41-dc9d-455b-a0a1-49e396129291
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221116/d11f0410/attachment-0005.png>