[JIRA] (JOIDC-106) SAML Metadata for OIDC does not support space delimiter in response_types

[Sam Bennett (Jira)]

Sam Bennett ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=61952ef6f24150007250af47 ) *created* an issue

IdP Plugin - OIDC OP ( https://shibboleth.atlassian.net/browse/JOIDC?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JOIDC-106?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 ) JOIDC-106 ( https://shibboleth.atlassian.net/browse/JOIDC-106?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 ) SAML Metadata for OIDC does not support space delimiter in response_types ( https://shibboleth.atlassian.net/browse/JOIDC-106?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) Created: 19/May/22 4:48 PM Priority: Trivial Reporter: Sam Bennett ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=61952ef6f24150007250af47 )

We have a system that is sending response_type=code%20id_token in the URL to the /authorize endpoint, and shib is giving us an error that says "WARN [net.shibboleth.idp.plugin.oidc.op.profile.impl.ValidateResponseType:47] - Profile Action ValidateResponseType: The response type code id_token is not registered for this RP|9097414F5FCA5BBA1F9B3AC8187C499A|10.173.101.1". We have the response_types listed in the metadata for that object:<md:EntityDescriptor
xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata"
xmlns:mdattr="urn:oasis:names:tc:SAML:metadata:attribute"
xmlns:oidcmd="urn:mace:shibboleth:metadata:oidc:1.0"
entityID=" esmjhop-id-uat.emporos.io ( http://esmjhop-id-uat.emporos.io/ ) ">
<md:SPSSODescriptor protocolSupportEnumeration=" http://openid.net/specs/openid-connect-core-1_0.html ">
<md:Extensions>
<oidcmd:OAuthRPExtensions
grant_types="authorization_code implicit"
response_types="code id_token"
token_endpoint_auth_method="client_secret_basic"
scopes="openid info profile email address phone" />
</md:Extensions>
<md:KeyDescriptor>
<ds:KeyInfo xmlns:ds=" http://www.w3.org/2000/09/xmldsig# ">
<oidcmd:ClientSecret> *redacted* </oidcmd:ClientSecret>
</ds:KeyInfo>
</md:KeyDescriptor>
<md:NameIDFormat>urn:mace:shibboleth:metadata:oidc:1.0:nameid-format:public</md:NameIDFormat>
<md:AssertionConsumerService
Binding=" https://tools.ietf.org/html/rfc6749#section-3.1.2 "
Location=" https://esmjhop-id-uat.emporos.io/signin-aad "
index="1"/>
<md:AssertionConsumerService
Binding=" https://tools.ietf.org/html/rfc6749#section-3.1.2 "
Location=" https://localhost:44378/signin-aad "
index="2"/>
<md:AssertionConsumerService
Binding=" https://tools.ietf.org/html/rfc6749#section-3.1.2 "
Location=" https://esmjhop-id-uat.emporos.io/signin-oidc "
index="3"/>
</md:SPSSODescriptor>
</md:EntityDescriptor>

So we see the response_types are both there. If we manually edit the authorize URL and take out code%20, it works.

Seems to be a bug in the parsing of the XML metadata per Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

( https://shibboleth.atlassian.net/browse/JOIDC-106#add-comment?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-106#add-comment?atlOrigin=eyJpIjoiNGUwZWMwZmY0YjA2NDQ0NTgxZDUxNjBmMDVlNzA1MTgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100198- sha1:0f60739 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220519/a026c58a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-cbf6d648-6785-42e7-b773-1d38f6b88960
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220519/a026c58a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-33ae8df1-3728-4a89-8f79-3206e626fb72
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220519/a026c58a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5745a46a-29dc-44b8-911c-cbf49afc771b
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220519/a026c58a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-740c729c-f16a-44d3-b217-c25a55500598
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220519/a026c58a/attachment-0007.png>