[java-support] branch main updated: JSPT-89 IdleConectionSweeperTest needs review for timing inconsistencies

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-support.

View the commit online:
http://git.shibboleth.net/view/?p=java-support.git;a=commit;h=2129eb350f880e0440f909ae62bcb762506c29e9

The following commit(s) were added to refs/heads/main by this push:
     new 2129eb3  JSPT-89 IdleConectionSweeperTest needs review for timing inconsistencies
2129eb3 is described below

commit 2129eb350f880e0440f909ae62bcb762506c29e9
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon Mar 21 13:58:59 2022 +0000

    JSPT-89 IdleConectionSweeperTest needs review for timing inconsistencies
    
    https://shibboleth.atlassian.net/browse/JSPT-89
    
    Tidy up explicatory comment and supresss javadoc warning in some test files.
---
 .../java/support/httpclient/ContextHandlingHttpClientTest.java         | 1 +
 .../java/support/httpclient/FileCachingHttpClientBuilderTest.java      | 1 +
 .../utilities/java/support/httpclient/HttpClientBuilderTest.java       | 1 +
 .../utilities/java/support/httpclient/HttpClientSupportTest.java       | 1 +
 .../utilities/java/support/httpclient/IdleConectionSweeperTest.java    | 3 ++-
 .../java/support/httpclient/InMemoryCachingHttpClientBuilderTest.java  | 1 +
 6 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClientTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClientTest.java
index fca571b..36cebbb 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClientTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/ContextHandlingHttpClientTest.java
@@ -41,6 +41,7 @@ import org.testng.annotations.BeforeClass;
 import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
+ at SuppressWarnings("javadoc")
 public class ContextHandlingHttpClientTest {
     
     public static final CloseableHttpResponse STATIC_RESPONSE_HTTP = new MockCloseableHttpResponse(new ProtocolVersion("HTTP", 1, 1), HttpStatus.SC_OK, "OK");
diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/FileCachingHttpClientBuilderTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/FileCachingHttpClientBuilderTest.java
index dbfeb93..fbe241e 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/FileCachingHttpClientBuilderTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/FileCachingHttpClientBuilderTest.java
@@ -20,6 +20,7 @@ package net.shibboleth.utilities.java.support.httpclient;
 import org.apache.http.client.HttpClient;
 import org.testng.annotations.Test;
 
+ at SuppressWarnings("javadoc")
 public class FileCachingHttpClientBuilderTest {
     
     @Test
diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilderTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilderTest.java
index 69b948b..a3a948d 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilderTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientBuilderTest.java
@@ -30,6 +30,7 @@ import org.testng.annotations.Test;
 
 import net.shibboleth.utilities.java.support.logic.ConstraintViolationException;
 
+ at SuppressWarnings("javadoc")
 public class HttpClientBuilderTest {
     
     // Default timeouts
diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientSupportTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientSupportTest.java
index e89d53d..7b018d0 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientSupportTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/HttpClientSupportTest.java
@@ -26,6 +26,7 @@ import org.apache.http.client.protocol.HttpClientContext;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
+ at SuppressWarnings("javadoc")
 public class HttpClientSupportTest {
 
 
diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/IdleConectionSweeperTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/IdleConectionSweeperTest.java
index 977bd72..59d0b64 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/IdleConectionSweeperTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/IdleConectionSweeperTest.java
@@ -28,6 +28,7 @@ import org.testng.annotations.Test;
 import net.shibboleth.utilities.java.support.component.DestroyedComponentException;
 
 /** {@link IdleConnectionSweeper} unit test. */
+ at SuppressWarnings("javadoc")
 public class IdleConectionSweeperTest {
 
     private final Duration SWEEP_INTERVAL = Duration.ofMillis(50);
@@ -71,7 +72,7 @@ public class IdleConectionSweeperTest {
                 // Windows sometimes takes its time...
                 Thread.sleep(SWEEP_INTERVAL.toMillis());
                 Thread.yield();
-                Assert.assertTrue(++loopCount != 5); // 5 time 50 ms is quarter of a second
+                Assert.assertTrue(++loopCount != 5); // 5 timed 50 ms is quarter of a second
             }
         }
 
diff --git a/src/test/java/net/shibboleth/utilities/java/support/httpclient/InMemoryCachingHttpClientBuilderTest.java b/src/test/java/net/shibboleth/utilities/java/support/httpclient/InMemoryCachingHttpClientBuilderTest.java
index 1697436..c90ce9b 100644
--- a/src/test/java/net/shibboleth/utilities/java/support/httpclient/InMemoryCachingHttpClientBuilderTest.java
+++ b/src/test/java/net/shibboleth/utilities/java/support/httpclient/InMemoryCachingHttpClientBuilderTest.java
@@ -20,6 +20,7 @@ package net.shibboleth.utilities.java.support.httpclient;
 import org.apache.http.client.HttpClient;
 import org.testng.annotations.Test;
 
+ at SuppressWarnings("javadoc")
 public class InMemoryCachingHttpClientBuilderTest {
     
     @Test

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.