[JIRA] (IDP-1888) Add duplicate property detection to the context initializer

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *resolved* as *Done*

Not sure why but the Path.endsWith method was not treating "idp.home/conf/idp.properties" as ending with Path.of("/conf/idp.properties"), despite this normally working as far as I've been able to tell in a typical system. The duplicate detection is I guess what caught it, it must be loading idp.properties twice all the time.

I converted it to a string-based check for endsWith, which I think is good enough. I don't think I care if somebody does something crazy like creates conf/something/conf/idp.properties and expects that to auto-load. It won't load now and inevitably somebody's gonna do that and bitch as soon as we ship this, but...

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-1888?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 ) IDP-1888 ( https://shibboleth.atlassian.net/browse/IDP-1888?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 ) Add duplicate property detection to the context initializer ( https://shibboleth.atlassian.net/browse/IDP-1888?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 )

Change By: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Assignee: Rod Widdowson Scott Cantor Resolution: Done Status: Reopened Resolved Remaining Estimate: 0 minutes Time Spent: 45 1 hour, 30 minutes

( https://shibboleth.atlassian.net/browse/IDP-1888#add-comment?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1888#add-comment?atlOrigin=eyJpIjoiYjJmZjBmODFhNjc2NGU1OWE2OWQwNmY1OTllMTE3YzEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:81e38da )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220317/a0b23049/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-29bcaf50-5989-4072-956a-f409886d8e0d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220317/a0b23049/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5a082680-1326-4842-a9e3-f287e271bbf2
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220317/a0b23049/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-71867ab3-da53-4b8c-9c56-f4e33e0c406f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220317/a0b23049/attachment-0005.png>