[JIRA] (JOIDC-78) Wrong JSONObject type when decoding claims from Signed JAR Authentication request

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-78 ( https://shibboleth.atlassian.net/browse/JOIDC-78?atlOrigin=eyJpIjoiOWFkM2FmOGU3ZGUwNDk2MThiMmQ1MGQ4M2U3ZDhjNDkiLCJwIjoiaiJ9 )

Re: Wrong JSONObject type when decoding claims from Signed JAR Authentication request ( https://shibboleth.atlassian.net/browse/JOIDC-78?atlOrigin=eyJpIjoiOWFkM2FmOGU3ZGUwNDk2MThiMmQ1MGQ4M2U3ZDhjNDkiLCJwIjoiaiJ9 )

This problem could be reproduced also with the plugin’s 3.1 -codebase, involving newer version of Nimbus libraries.

As noted by Simone, JSONObject (shaded or not) extends a Map. One and possibly the simplest approach would be to change DefaultRequestedClaimsLookupFunction into checking if the claims object is a Map , and in that case build a non-shaded JSONObject (net.minidev.json.JSONObject) from it. There's an existing constructor in JSONObject for that. The newly constructed JSONObject could then be fed for the IDCClaimsRequest.parse(..) method.

( https://shibboleth.atlassian.net/browse/JOIDC-78#add-comment?atlOrigin=eyJpIjoiOWFkM2FmOGU3ZGUwNDk2MThiMmQ1MGQ4M2U3ZDhjNDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-78#add-comment?atlOrigin=eyJpIjoiOWFkM2FmOGU3ZGUwNDk2MThiMmQ1MGQ4M2U3ZDhjNDkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:b6de2d8 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/16e9bb7d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-bdea9606-c42c-4e70-895f-3dbd0b93c6a3
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/16e9bb7d/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5fbe35ca-4213-40ae-a09c-d7303e815bd6
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/16e9bb7d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-79cbc8f1-f105-4550-8f58-52adfd3c4b79
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/16e9bb7d/attachment-0005.png>