[JIRA] (JOIDC-78) Wrong JSONObject type when decoding claims from Signed JAR Authentication request

[Simone Avogadro (Jira)]

Simone Avogadro ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A60a84ee1-4961-471b-99d8-f67c05e24403 ) *commented* on JOIDC-78 ( https://shibboleth.atlassian.net/browse/JOIDC-78?atlOrigin=eyJpIjoiNzJmOTU2YWY5Nzg0NGQ5ZGI0ZDU0ZGYyMjZmMDg2MDciLCJwIjoiaiJ9 )

Re: Wrong JSONObject type when decoding claims from Signed JAR Authentication request ( https://shibboleth.atlassian.net/browse/JOIDC-78?atlOrigin=eyJpIjoiNzJmOTU2YWY5Nzg0NGQ5ZGI0ZDU0ZGYyMjZmMDg2MDciLCJwIjoiaiJ9 )

Makes sense, passing thru a String also other positive side-effects, maybe some additional considerations:

* the current com.nimbusdds.jose.shaded.json.JSONObject is a Map<K,V>
* .toString should properly serialize the object and this is usually true in other JSON implementations
* using the standard Nimbusds libs to compose the signed request will place the claims inside a string (which is indeed a representation of the JSON) instead of using a JSONObject

* "claims":"{\"id_token\":{\"given_name\":{\"essential\":true ,\"userinfo\":{\"family_name\": {\"essential\":true}

 }} " }} 

* instead of an object as we’d expect "claims":{"id_token":{"given_name":{"essential":true ,"userinfo":
Unknown macro: {"family_name"}

 }}} 

( https://shibboleth.atlassian.net/browse/JOIDC-78#add-comment?atlOrigin=eyJpIjoiNzJmOTU2YWY5Nzg0NGQ5ZGI0ZDU0ZGYyMjZmMDg2MDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-78#add-comment?atlOrigin=eyJpIjoiNzJmOTU2YWY5Nzg0NGQ5ZGI0ZDU0ZGYyMjZmMDg2MDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100197- sha1:b6de2d8 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/b4e0cbcd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-25a1e613-dddf-449e-907d-dae8afac9793
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/b4e0cbcd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e01ba4f8-05fb-49ad-ae6c-8cdbff54e60a
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/b4e0cbcd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b9e176e4-d66c-4876-83bb-ec20a988656c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220310/b4e0cbcd/attachment-0005.png>