[JIRA] (IDP-1955) Add attachClasses to the maven-war-plugin in idp-parent

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1955 ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMDk4OWI1MmVjNzgxNGRkMmExNWMzZmM1YjNiZDA4YTUiLCJwIjoiaiJ9 )

Re: Add attachClasses to the maven-war-plugin in idp-parent ( https://shibboleth.atlassian.net/browse/IDP-1955?atlOrigin=eyJpIjoiMDk4OWI1MmVjNzgxNGRkMmExNWMzZmM1YjNiZDA4YTUiLCJwIjoiaiJ9 )

Hmm, so I guess I’m sort of “not surprised” here, given the docs, but when I apply that POM patch and build/install, the two jars I see added under idp-war and idp-war-distribution in the repo are essentially empty. Is that the expected result?

I can imagine that acting as a sort of “stub” for Maven in a sense, and it would be walking back from that artifact to the POM in the repo to compute the dependency tree and that’s what you’re actually trying to get it to leverage.

This kind of feels like a Maven bug to me, they should simply do that for the war to begin with, so I’m back to “this isn’t intentional behavior” but I can see that it’s pretty harmless on the build side.

( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMDk4OWI1MmVjNzgxNGRkMmExNWMzZmM1YjNiZDA4YTUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1955#add-comment?atlOrigin=eyJpIjoiMDk4OWI1MmVjNzgxNGRkMmExNWMzZmM1YjNiZDA4YTUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:66eda1f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/5c99d6a1/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-105f9fe7-a620-4cb2-b2c3-467ed8155ce0
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/5c99d6a1/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-0f05ebb7-90f3-471d-89aa-658a91b154f8
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/5c99d6a1/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-2dd6a7b7-ee21-431b-be2d-99fa8a807c8c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220628/5c99d6a1/attachment-0005.png>