[JIRA] (JOIDC-114) Single broken key in JwksData (SAML metadata) makes whole keyset invalid

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-114 ( https://shibboleth.atlassian.net/browse/JOIDC-114?atlOrigin=eyJpIjoiZTU2NzcwNGMyMTAyNDhjMTk4YjViZmVlMzVjNGJiYTciLCJwIjoiaiJ9 )

Re: Single broken key in JwksData (SAML metadata) makes whole keyset invalid ( https://shibboleth.atlassian.net/browse/JOIDC-114?atlOrigin=eyJpIjoiZTU2NzcwNGMyMTAyNDhjMTk4YjViZmVlMzVjNGJiYTciLCJwIjoiaiJ9 )

We currently use com.nimbusds.jose.jwk.JWKSet.parse(string) for attempting to parse the JWKSet. If it fails, then com.nimbusds.jose.jwk.JWK.parse(string) }} is attempted. They only log on *DEBUG* level on  {{ net.shibboleth.oidc.metadata.keyinfo.ext.impl.provider.InlineJwksProvider.

It’s not straightforward to support partial results from a JWKSet, as in that case we should parse the input JSON by ourselves and process one key at a time.

The simplest solution for improving logging would be to gather the parsing exceptions from both JWKSet.parse and JWK.parse , and produce a *WARN* -logline if both threw exception (i.e. neither could parse the input).

( https://shibboleth.atlassian.net/browse/JOIDC-114#add-comment?atlOrigin=eyJpIjoiZTU2NzcwNGMyMTAyNDhjMTk4YjViZmVlMzVjNGJiYTciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-114#add-comment?atlOrigin=eyJpIjoiZTU2NzcwNGMyMTAyNDhjMTk4YjViZmVlMzVjNGJiYTciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100201- sha1:5c1db44 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220623/30869b09/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-701131cc-e525-4654-b934-f2e8c1cc1824
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220623/30869b09/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-afd9ac6b-9d89-4664-b172-fe9c65e5a192
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220623/30869b09/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d134d6ad-15c3-4d2d-9ddc-29528a05e552
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220623/30869b09/attachment-0005.png>