[JIRA] (JOIDC-51) Need to populate an SPSession for each OIDC RP accessed

[Henri Mikkonen (Jira)]

Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-51 ( https://shibboleth.atlassian.net/browse/JOIDC-51?atlOrigin=eyJpIjoiMjNlMGI3ODdiNWVhNDM5NzliMDkxNjE5MTJmYzRjNDQiLCJwIjoiaiJ9 )

Re: Need to populate an SPSession for each OIDC RP accessed ( https://shibboleth.atlassian.net/browse/JOIDC-51?atlOrigin=eyJpIjoiMjNlMGI3ODdiNWVhNDM5NzliMDkxNjE5MTJmYzRjNDQiLCJwIjoiaiJ9 )

I verified that SAML2SPSessionCreationStrategy creates BasicSPSessions for OIDC RPs, as its code contains the following if-clause:

       final Pair<Assertion, AuthnStatement> result = getAssertionAndStatement(input);
       if (result == null) {
           log.info("Creating BasicSPSession in the absence of necessary information");
           final Instant now = Instant.now();
           return new BasicSPSession(issuer, now, now.plus(sessionLifetime));
       }

I fully agree that we should create OIDCSPSession once the logout is supported, but at this point I feel that BasicSPSession creation by default is satisfactory. However, a new property idp.oidc.SPSessionCreationStrategy enables injecting a custom session creation strategy already, but I kept the default at the SAML2 one that creates BasicSPSessions.

Once https://shibboleth.atlassian.net/browse/JOIDC-13 is implemented, it should contain creation of OIDCSPSessions, and by then we’ll also know what properties that class should carry.

( https://shibboleth.atlassian.net/browse/JOIDC-51#add-comment?atlOrigin=eyJpIjoiMjNlMGI3ODdiNWVhNDM5NzliMDkxNjE5MTJmYzRjNDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-51#add-comment?atlOrigin=eyJpIjoiMjNlMGI3ODdiNWVhNDM5NzliMDkxNjE5MTJmYzRjNDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100200- sha1:68eb57f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220614/adb5ff1e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6e4dfb1a-e3d4-42ce-b891-e41d839d328f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220614/adb5ff1e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8fdab604-9cc4-41a0-af6e-dee5634763fc
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220614/adb5ff1e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a451366f-4d51-433d-90a0-351eb9a60732
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220614/adb5ff1e/attachment-0005.png>