[java-idp-oidc] branch main updated: JOIDC-51 - Need to populate an SPSession for each OIDC RP accessed

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-idp-oidc.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-oidc.git;a=commit;h=7d6add1d2463280de83937dd3c55c1d4bf63587b

The following commit(s) were added to refs/heads/main by this push:
     new 7d6add1d JOIDC-51 - Need to populate an SPSession for each OIDC RP accessed
7d6add1d is described below

commit 7d6add1d2463280de83937dd3c55c1d4bf63587b
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Tue Jun 14 10:40:49 2022 +0300

    JOIDC-51 - Need to populate an SPSession for each OIDC RP accessed
    
    https://shibboleth.atlassian.net/browse/JOIDC-51
    
    Supports 'idp.oidc.SPSessionCreationStrategy' property for wiring
    custom creation strategy. The default strategy is still SAML2SPSessionCreationStrategy,
    that builds protocol-indepedent BasicSPSession.
---
 .../shibboleth/idp/flows/oidc/authorize/authorize-beans.xml   | 11 +++++------
 .../net/shibboleth/idp/plugin/oidc/op/conf/oidc.properties    |  3 +++
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/authorize/authorize-beans.xml b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/authorize/authorize-beans.xml
index d2c929c0..b4f01e81 100644
--- a/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/authorize/authorize-beans.xml
+++ b/idp-oidc-extension-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/oidc/authorize/authorize-beans.xml
@@ -562,12 +562,11 @@
     <bean id="UpdateSessionWithSPSession"
             class="net.shibboleth.idp.session.impl.UpdateSessionWithSPSession" scope="prototype"
             p:activationCondition="%{idp.session.trackSPSessions:false}"
-            p:sessionManager-ref="shibboleth.SessionManager">
-        <property name="SPSessionCreationStrategy">
-            <bean class="net.shibboleth.idp.saml.session.impl.SAML2SPSessionCreationStrategy"
-                c:lifetime="%{idp.session.defaultSPlifetime:PT2H}"/>
-        </property>
-    </bean>
+            p:sessionManager-ref="shibboleth.SessionManager"
+            p:SPSessionCreationStrategy-ref="%{idp.oidc.SPSessionCreationStrategy:DefaultSPSessionCreationStrategy}"/>
+
+    <bean id="DefaultSPSessionCreationStrategy" class="net.shibboleth.idp.saml.session.impl.SAML2SPSessionCreationStrategy"
+        c:lifetime="%{idp.session.defaultSPlifetime:PT2H}"/>
 
     <bean id="FormOutboundMessage"
         class="net.shibboleth.idp.plugin.oidc.op.profile.impl.FormOutboundAuthenticationResponseMessage" scope="prototype" />
diff --git a/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/oidc.properties b/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/oidc.properties
index 80115b02..97141932 100644
--- a/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/oidc.properties
+++ b/idp-oidc-extension-impl/src/main/resources/net/shibboleth/idp/plugin/oidc/op/conf/oidc.properties
@@ -96,6 +96,9 @@ idp.oidc.subject.salt = this_too_should_be_ch4ng3d
 # Bean used for extracting login_hint from the authentication request. The default function parses login_hint as is.
 #idp.oidc.LoginHintLookupStrategy = DefaultRequestLoginHintLookupFunction
 
+# Bean used for creating SPSessions needed for SLO. By default builds protocol-independent BasicSPSession, as SLO is not yet supported.
+#idp.oidc.SPSessionCreationStrategy = DefaultSPSessionCreationStrategy
+
 # Settings for issue-registration-access-token flow
 #idp.oidc.admin.registration.logging = IssueRegistrationAccessToken
 #idp.oidc.admin.registration.nonBrowserSupported = true

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.