[JIRA] (IDP-1793) Use Suppliers for HttpRequest/Response

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1793 ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiY2MyNGQ3NTAwOGQ4NDVmMWFjOTRiMmE1NWRiNmQ2NTEiLCJwIjoiaiJ9 )

Re: Use Suppliers for HttpRequest/Response ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiY2MyNGQ3NTAwOGQ4NDVmMWFjOTRiMmE1NWRiNmQ2NTEiLCJwIjoiaiJ9 )

This is going to be very long and quite tedious.

* The context I cared about (the RPUIContext) already has a supplier and we use sleight of hand to populate it (if what we are given is a ThreadLocalHttpServletRequestProxy then we reuturn it , otherwise null.
* Other classes (StorageBackedSessionManager, CookieManager) are singleton scope but have shibboleth.HttpRequest injected (which is the threadlocal thingy) and so they work by accident and could be changed.
* Still others ( MetadataQueryRequestDecoder are prototype scope).

It is going to be a very long job to do a thorough audit. And we will only be good for as long as noone decides to change a prototype scoped bean into a singleton.

I don’t mind doing the audit - but do we think this is the best use of our time?

( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiY2MyNGQ3NTAwOGQ4NDVmMWFjOTRiMmE1NWRiNmQ2NTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiY2MyNGQ3NTAwOGQ4NDVmMWFjOTRiMmE1NWRiNmQ2NTEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:0ba1f75 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220723/06fa1054/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6bee6e23-79be-4f74-88db-6db7bd4688a7
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220723/06fa1054/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-00e0e7bf-e4c0-45d4-9cc9-d68dc5427a59
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220723/06fa1054/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-66bfcf71-6669-43e2-b843-90c7af85dbe3
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220723/06fa1054/attachment-0005.png>