[JIRA] (IDP-1793) Use Suppliers for HttpRequest/Response

Scott Cantor (Jira) jira at shibboleth.atlassian.net
Mon Jul 18 14:33:00 UTC 2022


Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1793 ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiNWI3MzA1YjRiNmRmNDdhOGI1NTY5MDVhNzgzZDJhMmIiLCJwIjoiaiJ9 )

Re: Use Suppliers for HttpRequest/Response ( https://shibboleth.atlassian.net/browse/IDP-1793?atlOrigin=eyJpIjoiNWI3MzA1YjRiNmRmNDdhOGI1NTY5MDVhNzgzZDJhMmIiLCJwIjoiaiJ9 )

IIRC the motivation here was that we do this in a bunch of singletons where by all rights it would be totally wrong to do it. I guess the question is whether this would need to hapen everywhere or “just” expected singletons, but OTOH, I think some of the singletons are also the most common cases that would hit deployers.

If we really want to do this, we probably need to do it for 4.3 alongside the original setters and deprecate/warn on the direct setters.

( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiNWI3MzA1YjRiNmRmNDdhOGI1NTY5MDVhNzgzZDJhMmIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1793#add-comment?atlOrigin=eyJpIjoiNWI3MzA1YjRiNmRmNDdhOGI1NTY5MDVhNzgzZDJhMmIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:6e4678f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220718/6945ab57/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-95390419-df74-4492-a628-68a5b20c1814
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220718/6945ab57/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-995191d2-d222-4547-b277-7394501c8f4e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220718/6945ab57/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c86b4ca8-4c70-45c5-81f1-01674f902e53
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220718/6945ab57/attachment-0005.png>


More information about the commits mailing list