[JIRA] (IDP-1735) Filter matchAny function changes value order

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-1735 ( https://shibboleth.atlassian.net/browse/IDP-1735?atlOrigin=eyJpIjoiODAwOWMzNDI2YzU5NDE1MWIxMjFlYjA4YmZhOWQ0YzUiLCJwIjoiaiJ9 )

Re: Filter matchAny function changes value order ( https://shibboleth.atlassian.net/browse/IDP-1735?atlOrigin=eyJpIjoiODAwOWMzNDI2YzU5NDE1MWIxMjFlYjA4YmZhOWQ0YzUiLCJwIjoiaiJ9 )

Another interesting question lies in the use of the stream api’s for Set creation. Consider the following (from AttributeInMetadataMatcher

final Set<IdPAttributeValue> result = attribute.getValues().stream().
               filter(v -> requestedValues.contains(v)).collect(Collectors.toUnmodifiableSet());

I’m assuming that if this was a List (and used Collectors.toUnmodifiableList() ) then the order would be preserved (or at least one would hope it might). But that code has an absolute right to change the enumeration order every time it runs.

( https://shibboleth.atlassian.net/browse/IDP-1735#add-comment?atlOrigin=eyJpIjoiODAwOWMzNDI2YzU5NDE1MWIxMjFlYjA4YmZhOWQ0YzUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1735#add-comment?atlOrigin=eyJpIjoiODAwOWMzNDI2YzU5NDE1MWIxMjFlYjA4YmZhOWQ0YzUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:c075b5d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/217a445d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-d2c4904a-e981-4f98-a9fd-ae6ddcc3df96
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/217a445d/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-eca3ab34-22e9-4fe7-88d4-4fd7d211cecf
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/217a445d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b5f9faf1-1b98-46bf-b78e-b2b732a2ee88
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220721/217a445d/attachment-0005.png>