[JIRA] (IDP-1970) SAML Proxy: EventContext retrieved from the wrong profile context after message encoding

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on IDP-1970 ( https://shibboleth.atlassian.net/browse/IDP-1970?atlOrigin=eyJpIjoiMzkyNGEyYzJjNDAyNDUyY2FiMmZmM2UzM2I3NzIzMDMiLCJwIjoiaiJ9 )

Re: SAML Proxy: EventContext retrieved from the wrong profile context after message encoding ( https://shibboleth.atlassian.net/browse/IDP-1970?atlOrigin=eyJpIjoiMzkyNGEyYzJjNDAyNDUyY2FiMmZmM2UzM2I3NzIzMDMiLCJwIjoiaiJ9 )

I hard coded throwing a MessageEncodingException in the BaseHttpServletResponseXMLMessageEncoder and tested it in the testbed. The EncodeMessage action is adding the error EventContext as a subcontext to the profile request context it is given - which in this case is the nestedPRC.

Hence the SAMLAuthnController is failing to pull it out using: final EventContext eventCtx = prc.getSubcontext(EventContext.class); and it does not add the authentication error to the httpRequest.

I switched it over to using the nestedPRC and it worked.

( https://shibboleth.atlassian.net/browse/IDP-1970#add-comment?atlOrigin=eyJpIjoiMzkyNGEyYzJjNDAyNDUyY2FiMmZmM2UzM2I3NzIzMDMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1970#add-comment?atlOrigin=eyJpIjoiMzkyNGEyYzJjNDAyNDUyY2FiMmZmM2UzM2I3NzIzMDMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:0f3e007 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/c593bac4/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5cf2b0ef-6443-4f29-a7fc-b2c318103a73
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/c593bac4/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-779be9de-ee85-41d7-9250-938a1aaefa5f
Type: image/png
Size: 425 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/c593bac4/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-214fc368-432c-4464-b274-d8590caac66d
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220713/c593bac4/attachment-0005.png>