[JIRA] (IDP-1972) Revisit deferred classnames for solving layering conflicts

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-1972?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 ) IDP-1972 ( https://shibboleth.atlassian.net/browse/IDP-1972?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 ) Revisit deferred classnames for solving layering conflicts ( https://shibboleth.atlassian.net/browse/IDP-1972?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Attribute Filter, Attribute Resolver, Metadata Created: 11/Jul/22 5:31 PM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

There are several places in the refactored metadata and attribute libraries that rely on IdP classes. The current workaround for this is to hardcode IdP classnames into various Spring parsers in those new libraries and instantiate the classes at runtime to use them in bean definition builders.

If we feel the need to improve this with a more robust solution, this is a summary of where the trick was used:

* net.shibboleth.spring.metadata.filter.PredicateFilterParser
* net.shibboleth.idp.attribute.resolver.spring.BaseResolverPluginParser
* net.shibboleth.idp.attribute.resolver.spring.dc.impl.SubjectDataConnectorParser
* net.shibboleth.idp.attribute.resolver.spring.ad.impl.SubjectDerivedAttributeDefinitionParser

( https://shibboleth.atlassian.net/browse/IDP-1972#add-comment?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1972#add-comment?atlOrigin=eyJpIjoiZjViYzFmZGEyN2FiNDEzNGJlMDQ1ZmRlZWZkMjVhZjkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100202- sha1:35f91a0 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220711/870eaa12/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-19b35563-29dd-4bb7-a7f4-5b60e856f1f2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220711/870eaa12/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-24ca71db-1fad-4d86-b35b-d2785948db22
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220711/870eaa12/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-93fa2a5a-7724-460c-89cc-23e66729eafb
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220711/870eaa12/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-3a13cd6a-d6be-4a3c-9fc2-b14ca6b67f26
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220711/870eaa12/attachment-0007.png>