[JIRA] (JCOMOIDC-41) Move OIDC Signature Validation resolvers and parameter classes to commons
Brent Putman (Jira)
jira at shibboleth.atlassian.net
Fri Feb 18 17:00:43 UTC 2022
Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *commented* on JCOMOIDC-41 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYmRjM2EyYTY4MjAzNDQ5NzhmZjc4MTMwYThiNTQzNmIiLCJwIjoiaiJ9 )
Re: Move OIDC Signature Validation resolvers and parameter classes to commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYmRjM2EyYTY4MjAzNDQ5NzhmZjc4MTMwYThiNTQzNmIiLCJwIjoiaiJ9 )
A couple of points/clarifications from the call etc:
* On the JWK → Credential resolution: I have some (prob temporary) inline code in the trust engine base class for this, using BasicJWKCredential. But what I meant was that it seems more clean to have a component like a Resolver that can take one of the SignedJWT super-interfaces (maybe JOSEObject?) and process the Header to produce Credential(s). Esp for supporting the resolution of remote JWK Key Set (jku header) in addition to inline. Will be much simpler than the KeyInfoCredentialResolver since Nimbus already does most of the work of parsing the raw data into key/cert objects, etc.
* The AlgorithmDescriptors here are somewhat misusing the getURI() of that interface and the AlgorithmRegistry in that the URI properties aren’t actually URIs, just the naked JOSE algo IDs. It “works” b/c they’re all just Strings, but aside from the formalism doesn’t seem future-proof against future collisions. Would be more correct to invent a synthetic URI notion by prepending the JOSE ID with a local prefix, e.g. “ https://shibboleth.net/jose/algorightms/RS256” , etc. But that would entail all existing code using this stuff to be updated, and I don’t know how easy or hard that is.
( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYmRjM2EyYTY4MjAzNDQ5NzhmZjc4MTMwYThiNTQzNmIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYmRjM2EyYTY4MjAzNDQ5NzhmZjc4MTMwYThiNTQzNmIiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:0395bb9 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/2ed3a17c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6d5bec07-921e-4d65-a102-af82b59ad9ff
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/2ed3a17c/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-42b68ae8-7ac6-40dc-ad32-bb2ca93b5c3a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/2ed3a17c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3ae6f3dc-da82-44d9-a45b-7272869e5a1b
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/2ed3a17c/attachment-0005.png>
More information about the commits
mailing list