[JIRA] (JCOMOIDC-41) Move OIDC Signature Validation resolvers and parameter classes to commons
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Fri Feb 18 01:53:37 UTC 2022
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-41 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYjU0YTczYWE2YTIzNDUyNWIzMTM3YTY3NGU4MmU0MDkiLCJwIjoiaiJ9 )
Re: Move OIDC Signature Validation resolvers and parameter classes to commons ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41?atlOrigin=eyJpIjoiYjU0YTczYWE2YTIzNDUyNWIzMTM3YTY3NGU4MmU0MDkiLCJwIjoiaiJ9 )
There should already be sufficient support in the JWKCredential/BasicJWKCredential classes, those seem to work pretty interchangeably with our existing Credential classes in the current code.
All the code was written to use the JOSE identifiers I think.
The signature validation class extends the wrong class because of the confusion they had over not having a TrustEngine to plug in and not understanding how to build one. They used the signing class because it carries Credentials, so they stuffed the verification keys into it and used it backwards.
Once we have a TrustEngine built and the right CredentialResolver in place, it should be possible to rewire all that.
( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYjU0YTczYWE2YTIzNDUyNWIzMTM3YTY3NGU4MmU0MDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-41#add-comment?atlOrigin=eyJpIjoiYjU0YTczYWE2YTIzNDUyNWIzMTM3YTY3NGU4MmU0MDkiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100192- sha1:e250074 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/42551df0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-8d1c442d-701d-4c1b-9df5-435db5305266
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/42551df0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-69fb6100-a486-4a67-a894-469029b2e7cc
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/42551df0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e22b96ab-29e5-41b1-800a-767457d1d905
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220218/42551df0/attachment-0005.png>
More information about the commits
mailing list