[JIRA] (JCOMOIDC-40) Complete OIDCAttributeTranscoder decode values function

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JCOMOIDC-40 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiOWRhYjE4MjM2MTRjNDE3Nzk4MjFhODNlNmJlNTg2ZjciLCJwIjoiaiJ9 )

Re: Complete OIDCAttributeTranscoder decode values function ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiOWRhYjE4MjM2MTRjNDE3Nzk4MjFhODNlNmJlNTg2ZjciLCJwIjoiaiJ9 )

I’m not following the code clearly but it looks like it probably should just re-derive the name to access inside doDecode(). It was really all very different to build because with SAML the objects it’s operating on are self-contained, where here the names are in the map as keys so you can’t just point to a single object to capture both the name and the value(s).

As far as the values, each type of transcoder class handles a specific value type, which is intended to be determinable from the claim itself, it’s not meant allow for generically typed claims. A JSON-based transcoder could be built that handles any type, essentially like we used to do to support XMLObjects. But the basic string case should fail if it didn’t find a string or an array.

To actually handle full JSON values, we would have to choose to implement a JSONAttributeValue subclass to represent that properly.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiOWRhYjE4MjM2MTRjNDE3Nzk4MjFhODNlNmJlNTg2ZjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiOWRhYjE4MjM2MTRjNDE3Nzk4MjFhODNlNmJlNTg2ZjciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100191- sha1:831671b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/81400bd9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-56009042-313e-4778-ae09-8354026f9f0b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/81400bd9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-61658035-9bb4-423a-b6ef-d4cbceb9f935
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/81400bd9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2f6a45a7-2c65-4286-869a-1e741d2b4fad
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/81400bd9/attachment-0005.png>