[JIRA] (JCOMOIDC-40) Complete OIDCAttributeTranscoder decode values function

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-40 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiMmNmOTZlMjIyZDM5NDg2MDhmNGFiMGNjNDU1ZmY0NDciLCJwIjoiaiJ9 )

Re: Complete OIDCAttributeTranscoder decode values function ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40?atlOrigin=eyJpIjoiMmNmOTZlMjIyZDM5NDg2MDhmNGFiMGNjNDU1ZmY0NDciLCJwIjoiaiJ9 )

It is the getEncodedName method that adds a prefix to the name of the OIDC claim which is then used to lookup the claim from the input JSONObject. I think that method needs to do that, so the registry can add a target to the mapping. But I am not sure the decode method needs to use it.

The abstract class AbstractOIDCAttributeTranscoder uses the parameterized type JSONObject. I think that can work, although I can not see a better way than adding instanceof checks to decode the actual values, as the JSONObject is really just a Map of <String, Object> , and so a set of cast conditionals to the allowable JSON types for the Object value seem necessary.

JSON Arrays can be handled recursively. But a nested JSON object is more tricky. I have put that together for now just by serializing whatever the JSONObject is into a single IdPAtttributeValue. Of the standard claims, the Address claim is a JSONObject type. So I may need to think about this more.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiMmNmOTZlMjIyZDM5NDg2MDhmNGFiMGNjNDU1ZmY0NDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-40#add-comment?atlOrigin=eyJpIjoiMmNmOTZlMjIyZDM5NDg2MDhmNGFiMGNjNDU1ZmY0NDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100191- sha1:831671b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/42812fd9/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-b0826ab9-4427-4e87-82d2-2bf7a0617e16
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/42812fd9/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-57c8a214-e83b-4928-b073-3ace947d849e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/42812fd9/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-bf0cc28f-0e60-412e-b967-9fb3ae339ee8
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220214/42812fd9/attachment-0005.png>