[JIRA] (IDP-2052) NPE when InputAttributeDefinition references nonexistant attribute

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2052 ( https://shibboleth.atlassian.net/browse/IDP-2052?atlOrigin=eyJpIjoiYzlmYTk5MGQ2N2JjNDNjNThmNWFkMzdhMjk1ODZmMWUiLCJwIjoiaiJ9 )

Re: NPE when InputAttributeDefinition references nonexistant attribute ( https://shibboleth.atlassian.net/browse/IDP-2052?atlOrigin=eyJpIjoiYzlmYTk5MGQ2N2JjNDNjNThmNWFkMzdhMjk1ODZmMWUiLCJwIjoiaiJ9 )

Stack doesn’t really help - its what you’d expect.

java.lang.NullPointerException: Cannot invoke "net.shibboleth.idp.attribute.resolver.ResolvedAttributeDefinition.getResolvedAttribute()" because "attributeDefinition" is null
	at net.shibboleth.idp.attribute.resolver.PluginDependencySupport.getMergedAttributeValues(PluginDependencySupport.java:87)
	at net.shibboleth.idp.attribute.resolver.ad.impl.SimpleAttributeDefinition.doAttributeDefinitionResolve(SimpleAttributeDefinition.java:69)
	at net.shibboleth.idp.attribute.resolver.AbstractAttributeDefinition.doResolve(AbstractAttributeDefinition.java:130)
	at net.shibboleth.idp.attribute.resolver.AbstractAttributeDefinition.doResolve(AbstractAttributeDefinition.java:1)
	at net.shibboleth.idp.attribute.resolver.AbstractResolverPlugin.resolve(AbstractResolverPlugin.java:260)
	at net.shibboleth.idp.attribute.resolver.impl.AttributeResolverImpl.resolveAttributeDefinition(AttributeResolverImpl.java:359)
	at net.shibboleth.idp.attribute.resolver.impl.AttributeResolverImpl.resolveAttributes(AttributeResolverImpl.java:283)

I’ve checked for timing windows in the service refresh stuff and cannot see one (once you realize that the underlying resolver is only ever replaced, never torn down).

The two places where the IDP resolves attributes all look OK as far as the protection against teardown locking goes and we definitely initialize (and hence check for mis spelt dependencies) before the resolver goes live.

I’m going to have to back burner this and hope that inspiration hits

( https://shibboleth.atlassian.net/browse/IDP-2052#add-comment?atlOrigin=eyJpIjoiYzlmYTk5MGQ2N2JjNDNjNThmNWFkMzdhMjk1ODZmMWUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2052#add-comment?atlOrigin=eyJpIjoiYzlmYTk5MGQ2N2JjNDNjNThmNWFkMzdhMjk1ODZmMWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100212- sha1:99773b8 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/08a11b0e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4ce466da-0fc0-4bc2-a61b-b7cc191216b9
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/08a11b0e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c3f91fb8-c5c6-4a30-8a6c-78b661e8ab31
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/08a11b0e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-cac15622-4c12-4003-b9f0-3775a64033bc
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/08a11b0e/attachment-0005.png>