[JIRA] (IDP-2052) NPE when InputAttributeDefinition references nonexistant attribute

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2052 ( https://shibboleth.atlassian.net/browse/IDP-2052?atlOrigin=eyJpIjoiZjQwNTNhN2ViYTgyNDcyYjg3Y2NlOTk5NjE2Y2Q0Y2YiLCJwIjoiaiJ9 )

Re: NPE when InputAttributeDefinition references nonexistant attribute ( https://shibboleth.atlassian.net/browse/IDP-2052?atlOrigin=eyJpIjoiZjQwNTNhN2ViYTgyNDcyYjg3Y2NlOTk5NjE2Y2Q0Y2YiLCJwIjoiaiJ9 )

When I try reproduce I fall over the warning

Attribute Resolver 'Shibboleth.Resolver': Plugin 'setup-to-fail' has a dependency on attribute definition 'undef2' which doesn't exist
	at net.shibboleth.idp.attribute.resolver.impl.AttributeResolverImpl.checkPlugInDependencies(AttributeResolverImpl.java:735)

I’m going to try to manual force a failure and grab a stack.

I’m currently stumped since the whole point of the Service Architecture is that

* The resolver is full initialized (and dependencies checked) before it becomes available to attribute resolution
* That the system is locked to stop resolution during teardown.
* The dependency failure is captured during initialization and the process of resolution cannot happen if the resolver is uninitialized.
* You cannot set/add dependencies, or definitions to an initialized resolver and the collections of these things are all unmodifiable.

I’ll poke at the debugger and read some more code.

( https://shibboleth.atlassian.net/browse/IDP-2052#add-comment?atlOrigin=eyJpIjoiZjQwNTNhN2ViYTgyNDcyYjg3Y2NlOTk5NjE2Y2Q0Y2YiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2052#add-comment?atlOrigin=eyJpIjoiZjQwNTNhN2ViYTgyNDcyYjg3Y2NlOTk5NjE2Y2Q0Y2YiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100212- sha1:99773b8 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/0ae477aa/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-cbd91c86-a436-49a2-bea2-f9ad09744af2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/0ae477aa/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2464942d-b066-429b-836b-7656ad500ad3
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/0ae477aa/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6d9b659c-4523-4e70-825f-92213902283f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20221212/0ae477aa/attachment-0005.png>