[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiMzI5Y2RlZmY2NjU0NDgyOWFjNzA5ZGIyNjAxN2Y2MDQiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiMzI5Y2RlZmY2NjU0NDgyOWFjNzA5ZGIyNjAxN2Y2MDQiLCJwIjoiaiJ9 )

I’ve re-reviewed this and I believe this to be correct. the reason being that the final methods in AbstractIdentifiedInitializableComponent are overriding the (non final) methods in AbstractInitializableComponent (the difference being that the identifiable component thows an exception with the name where as the unindentified component says “unknown component”).

The final methods in the unidentified component call these methods. So short of some baroque extra level of callback I don’t see any way to change the finality short of removing the identifier from the error message when you throw (perhaps replacing it with the class name?)

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiMzI5Y2RlZmY2NjU0NDgyOWFjNzA5ZGIyNjAxN2Y2MDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiMzI5Y2RlZmY2NjU0NDgyOWFjNzA5ZGIyNjAxN2Y2MDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100205- sha1:5460ff5 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/dcd2ad41/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-30c7cbc7-9d3d-4005-b037-171858f67aae
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/dcd2ad41/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c3850431-385d-463d-aa8e-e6ca6c82ee14
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/dcd2ad41/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-110e5197-d9c6-4283-933b-c268b0352f1c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/dcd2ad41/attachment-0005.png>