[JIRA] (JSPT-98) Integrate lifecycle checking methods in base classes

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on JSPT-98 ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiOThiYjZjNzdkMmQzNDk1ZTlmZWRlNmViODAzOTY1ZDkiLCJwIjoiaiJ9 )

Re: Integrate lifecycle checking methods in base classes ( https://shibboleth.atlassian.net/browse/JSPT-98?atlOrigin=eyJpIjoiOThiYjZjNzdkMmQzNDk1ZTlmZWRlNmViODAzOTY1ZDkiLCJwIjoiaiJ9 )

I appreciate your general sensitivity, but in this case I think you should take the opposite approach and make these things final in the Java 17 stack. The only thing it will affect immediately is my “compatibility with Java 17” branch, which will certainly break, but that’s a good thing as it avoids some duplication I didn’t notice on the first pass.

( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiOThiYjZjNzdkMmQzNDk1ZTlmZWRlNmViODAzOTY1ZDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSPT-98#add-comment?atlOrigin=eyJpIjoiOThiYjZjNzdkMmQzNDk1ZTlmZWRlNmViODAzOTY1ZDkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100205- sha1:5460ff5 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/44a33436/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-dcc72d88-f540-4ed1-bcd9-958da22d0295
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/44a33436/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-801d75c3-a7c5-40ce-8d67-6783c8f4a0a5
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/44a33436/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-bff30b09-d077-4074-9c44-af63d7f5f062
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220819/44a33436/attachment-0005.png>