[JIRA] (IDP-1991) review net.shibboleth.idp.session.impl.StorageBackedSessionManager

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/IDP-1991?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 ) IDP-1991 ( https://shibboleth.atlassian.net/browse/IDP-1991?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 ) review net.shibboleth.idp.session.impl.StorageBackedSessionManager ( https://shibboleth.atlassian.net/browse/IDP-1991?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 )

Issue Type: Task Affects Versions: 4.0.0, 4.1.0, 4.2.0, 4.2.1 Assignee: Unassigned Created: 06/Aug/22 9:23 AM Fix Versions: 4.3.0, 5.0.0 Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

Again as part of https://shibboleth.atlassian.net/browse/IDP-1793 I was in this module

It appears to have a setter for a HttpServletResponse but the field is never used

I mechanically changed the setter to take a supplier, but it seems to me that we could drop the field and the method entirely.

Someone else can pick this up or I’ll loop back sometime.

( https://shibboleth.atlassian.net/browse/IDP-1991#add-comment?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1991#add-comment?atlOrigin=eyJpIjoiNjNhYmM0NjVjYzc2NDc3YjlmMTAxNzA4NGFlMjJlODMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100204- sha1:d476756 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20220806/60f9900f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-286bb99e-3bb8-4bdd-996c-15ad37d0c364
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220806/60f9900f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-d2ab4842-9caf-49fc-b80f-16490a5b27e3
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220806/60f9900f/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-f8530c54-bb3d-45c6-9d0d-b917af0eb33e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220806/60f9900f/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-c8bf0afe-6c32-4825-919a-b91d1bf5ab1f
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20220806/60f9900f/attachment-0007.png>