[JIRA] (MDA-263) Observations about the Aggregator build

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-263 ( https://shibboleth.atlassian.net/browse/MDA-263?atlOrigin=eyJpIjoiNWI1YTZlZTU1YTIzNGI0NWEyZWFkZWNjNzYwNjE5YWYiLCJwIjoiaiJ9 )

Re: Observations about the Aggregator build ( https://shibboleth.atlassian.net/browse/MDA-263?atlOrigin=eyJpIjoiNWI1YTZlZTU1YTIzNGI0NWEyZWFkZWNjNzYwNjE5YWYiLCJwIjoiaiJ9 )

The build system in this project may be living in the land that time forgot, I haven’t tried to rationalise it other than tweaking the assembly file from time to time, so the Maven part is largely as Chad left it.

A lot of the configuration for the assembly is coming from the java-parent-project. In particular, the assembly part is bound to the package phase but only in the release profile. So to get it to build the distribution artifact (which ends up in aggregator-cli/target/aggregator-cli-0.10.0-SNAPSHOT-bin.zip ), you need to say mvn -Prelease clean package or the like. Without -Prelease it just builds the individual module.jar files.

I’ve had “why is everything useful only in the release profile” on my list to investigate for at least half a decade now, as this seems a bit strange. I haven’t wanted to bull in and rationalise anything as it might destabilise something I don’t understand.

I’m very happy to help with deep digging in the MDA context and potentially changing the way it does things if we can improve it in some way though.

( https://shibboleth.atlassian.net/browse/MDA-263#add-comment?atlOrigin=eyJpIjoiNWI1YTZlZTU1YTIzNGI0NWEyZWFkZWNjNzYwNjE5YWYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-263#add-comment?atlOrigin=eyJpIjoiNWI1YTZlZTU1YTIzNGI0NWEyZWFkZWNjNzYwNjE5YWYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100178- sha1:3031cab )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20210928/2eb2a949/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1d1a919f-c10a-45b9-91bc-99fe7d48483f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210928/2eb2a949/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a40b8115-7ab2-47e5-8bfa-75e09754a784
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210928/2eb2a949/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-10d4ba3c-34df-477f-a81b-a8d3f5f2fa6d
Type: image/png
Size: 468 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210928/2eb2a949/attachment-0005.png>