[JIRA] (IDP-1822) ScopedAttributePredicate

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1822 ( https://shibboleth.atlassian.net/browse/IDP-1822?atlOrigin=eyJpIjoiMDQ2MjVjMzIwOGUxNDI4MDk2ZDUwYzU1ZjU1MzJjZjYiLCJwIjoiaiJ9 )

Re: ScopedAttributePredicate ( https://shibboleth.atlassian.net/browse/IDP-1822?atlOrigin=eyJpIjoiMDQ2MjVjMzIwOGUxNDI4MDk2ZDUwYzU1ZjU1MzJjZjYiLCJwIjoiaiJ9 )

We already have the value portion, you copied that code into this contribution. I could inherit from our class and add Scope matching but that isn’t really necessary because it’s just as simple to wire them up with an AND (which is also more general since it allows for the scope check without bothering with the value if that’s not relevant to the condition).

My other point is that your code attached here doesn’t actually allow for that either. You have a single scope being matched, so it would be either universityA or B.

( https://shibboleth.atlassian.net/browse/IDP-1822#add-comment?atlOrigin=eyJpIjoiMDQ2MjVjMzIwOGUxNDI4MDk2ZDUwYzU1ZjU1MzJjZjYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1822#add-comment?atlOrigin=eyJpIjoiMDQ2MjVjMzIwOGUxNDI4MDk2ZDUwYzU1ZjU1MzJjZjYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:d14df9b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211109/3fceee94/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-ac911ea6-4098-41ce-998e-8ada78fc8f33
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211109/3fceee94/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8ba234d4-3bff-4e4a-a467-e411d8fe5583
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211109/3fceee94/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4e43b589-df43-4431-b580-38870d60dbde
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211109/3fceee94/attachment-0005.png>