[JIRA] (JCOMOIDC-23) Add OpenID Provider Configuration Document Resolver

Henri Mikkonen (Jira) jira at shibboleth.atlassian.net
Fri Nov 5 12:04:57 UTC 2021


Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JCOMOIDC-23 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23?atlOrigin=eyJpIjoiNmY5NGIwOGYyNzQ5NDZlOTk3NWUwNjdmZTU3MzA2M2YiLCJwIjoiaiJ9 )

Re: Add OpenID Provider Configuration Document Resolver ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23?atlOrigin=eyJpIjoiNmY5NGIwOGYyNzQ5NDZlOTk3NWUwNjdmZTU3MzA2M2YiLCJwIjoiaiJ9 )

As discussed on Slack, the metadata loading strategies should also support “optional” metadata resources. Regarding the metadata policy resolution, I’d like to enable optional policy-file resolution via property. The following works nicely only if the property  {{ idp.oidc.dynreg.defaultMetadataPolicyFile }} is defined:

   <bean id="shibboleth.oidc.dynreg.DefaultMetadataPolicyResolver"
       parent="shibboleth.oidc.dynreg.BaseMetadataPolicyResolver">
       <constructor-arg>
           <bean parent="shibboleth.oidc.dynreg.BatchCacheBuilder">
               <constructor-arg>
                   <bean p:cacheId="DefaultPolicyFileCache" parent="shibboleth.oidc.dynreg.BatchMetadataCacheBuilderSpec">
                       <property name="loadingStrategy">
                           <bean class="net.shibboleth.oidc.metadata.cache.impl.DefaultFileLoadingStrategy"
                               c:metadata="%{idp.oidc.dynreg.defaultMetadataPolicyFile:}" />
                       </property>
                   </bean>
               </constructor-arg>
           </bean>
       </constructor-arg>
   </bean>

Empty value should also be supported, as not all deployers will use the feature, and it’s not meaningful to require an empty JSON file to exist either. Could DefaultFileLoadingStrategy provide some flag to allow  {{ c:metadata }} to be empty?

( https://shibboleth.atlassian.net/browse/JCOMOIDC-23#add-comment?atlOrigin=eyJpIjoiNmY5NGIwOGYyNzQ5NDZlOTk3NWUwNjdmZTU3MzA2M2YiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-23#add-comment?atlOrigin=eyJpIjoiNmY5NGIwOGYyNzQ5NDZlOTk3NWUwNjdmZTU3MzA2M2YiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100183- sha1:8e458bc )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20211105/5e828953/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-576a1942-ab12-42b1-9003-b21a3892d520
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211105/5e828953/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b0e8f059-b0a1-47a5-86b8-5d26455db628
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211105/5e828953/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8b5a794f-5085-46a8-a6be-74c541297a38
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20211105/5e828953/attachment-0005.png>


More information about the commits mailing list