[JIRA] (IDP-1853) Consider bundling a Javascript plugin with the IdP distribution

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-1853?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 ) IDP-1853 ( https://shibboleth.atlassian.net/browse/IDP-1853?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 ) Consider bundling a Javascript plugin with the IdP distribution ( https://shibboleth.atlassian.net/browse/IDP-1853?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 )

Issue Type: Improvement Affects Versions: 4.1.4 Assignee: Unassigned Created: 16/Aug/21 6:34 AM Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

Java >= 15 no longer integrates a Javascript engine, and we don't ship one with the IdP.

The result of this is that if you upgrade a working IdP to Java 17, or deploy a new IdP under Java 17, instead of the tradititional "Nashorn is going to be removed" warning the IdP fails to start up. We knew this was coming, of course.

The actual failure messages are both obscure and buried in the Jetty logs (or I guess the Tomcat logs if you're using that container).

I think it would make sense to bundle one of our new Javascript plugins with upcoming versions of the IdP to make the transition transparent. The obvious one would be the scripting plugin based on the OpenJDK version of Nashorn, for max compatibility with the current (Java 11) environment.

We'd probably need to make it possible to deal with the case where the deployer doesn't want that one, but instead needs the Rhino-based plugin. And, of course, subsequent IdP upgrades shouldn't override that choice if it has been made (by uninstalling the Nashorn plugin and installing the Rhino one). One option would be to use the module system to allow multiple Javascript plugins to coexist but have some disabled.

( https://shibboleth.atlassian.net/browse/IDP-1853#add-comment?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1853#add-comment?atlOrigin=eyJpIjoiMDNiOWZjZTNlZmM0NDdlNWJjMWViNzRmNjA3NGI1OTEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100172- sha1:c3c6042 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20210816/d743746d/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-59f3add4-5286-4009-bd9c-253fe9f7f12a
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210816/d743746d/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-100b3e3f-1f4b-43a0-a89d-3b7fa887e2c6
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210816/d743746d/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-287bc3c7-20c6-4f80-a374-487ea332f2f3
Type: image/png
Size: 563 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210816/d743746d/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-532b3ed1-73a5-4a80-85e6-85e3447747c8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20210816/d743746d/attachment-0007.png>