[java-opensaml] 02/04: JPAR-85 - Checkstyle, check final variables
Tom Zeller
tzeller at dragonacea.biz
Wed Aug 9 23:27:10 EDT 2017
This is an automated email from the git hooks/post-receive script.
tzeller pushed a commit to branch master
in repository java-opensaml.
View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=ad5b04150832e39bb53a2e35b4ffb5b5d27762f9
commit ad5b04150832e39bb53a2e35b4ffb5b5d27762f9
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Wed Aug 9 22:01:01 2017 -0500
JPAR-85 - Checkstyle, check final variables
---
.../http/AbstractPipelineHttpSOAPClient.java | 25 ++++++++--------
.../soap/common/AbstractExtensibleSOAPObject.java | 2 +-
.../soap/common/SOAP11FaultDecodingException.java | 4 +--
.../soap/messaging/SOAPMessagingSupport.java | 28 +++++++++---------
.../java/org/opensaml/soap/util/SOAPSupport.java | 33 +++++++++++-----------
.../wsaddressing/util/WSAddressingSupport.java | 4 +--
.../messaging/WSSecurityMessagingSupport.java | 9 +++---
.../soap/wssecurity/util/WSSecuritySupport.java | 8 +++---
8 files changed, 58 insertions(+), 55 deletions(-)
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
index 63288fd..e67e3b1 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
@@ -198,11 +198,11 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
pipeline.getOutboundPayloadMessageHandler().invoke(operationContext.getOutboundMessageContext());
}
- HttpUriRequest httpRequest = buildHttpRequest(endpoint, operationContext);
- HttpClientContext httpContext = buildHttpContext(httpRequest, operationContext);
+ final HttpUriRequest httpRequest = buildHttpRequest(endpoint, operationContext);
+ final HttpClientContext httpContext = buildHttpContext(httpRequest, operationContext);
// Request encoding + outbound transport handling
- HttpClientRequestMessageEncoder<OutboundMessageType> encoder = pipeline.getEncoder();
+ final HttpClientRequestMessageEncoder<OutboundMessageType> encoder = pipeline.getEncoder();
encoder.setHttpRequest(httpRequest);
encoder.setMessageContext(operationContext.getOutboundMessageContext());
encoder.initialize();
@@ -213,11 +213,11 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
encoder.encode();
// HttpClient execution
- HttpResponse httpResponse = getHttpClient().execute(httpRequest, httpContext);
+ final HttpResponse httpResponse = getHttpClient().execute(httpRequest, httpContext);
HttpClientSecuritySupport.checkTLSCredentialEvaluated(httpContext, httpRequest.getURI().getScheme());
// Response decoding
- HttpClientResponseMessageDecoder<InboundMessageType> decoder = pipeline.getDecoder();
+ final HttpClientResponseMessageDecoder<InboundMessageType> decoder = pipeline.getDecoder();
decoder.setHttpResponse(httpResponse);
decoder.initialize();
decoder.decode();
@@ -229,7 +229,7 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
}
} catch (final SOAP11FaultDecodingException e) {
- SOAPFaultException faultException = new SOAPFaultException(e.getMessage(), e);
+ final SOAPFaultException faultException = new SOAPFaultException(e.getMessage(), e);
faultException.setFault(e.getFault());
throw faultException;
} catch (final SSLException e) {
@@ -337,9 +337,10 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
@Nonnull protected HttpClientContext buildHttpContext(@Nonnull final HttpUriRequest request,
@Nonnull final InOutOperationContext operationContext) {
- HttpClientContext clientContext = resolveClientContext(operationContext);
+ final HttpClientContext clientContext = resolveClientContext(operationContext);
- HttpClientSecurityParameters contextSecurityParameters = resolveContextSecurityParameters(operationContext);
+ final HttpClientSecurityParameters contextSecurityParameters =
+ resolveContextSecurityParameters(operationContext);
HttpClientSecuritySupport.marshalSecurityParameters(clientContext, contextSecurityParameters, false);
@@ -376,7 +377,7 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
*/
protected HttpClientSecurityParameters resolveContextSecurityParameters(
@Nonnull final InOutOperationContext operationContext) {
- HttpClientSecurityContext securityContext =
+ final HttpClientSecurityContext securityContext =
operationContext.getOutboundMessageContext().getSubcontext(HttpClientSecurityContext.class);
if (securityContext != null) {
return securityContext.getSecurityParameters();
@@ -404,7 +405,7 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
* @return the effective client context instance to use
*/
@Nonnull protected HttpClientContext resolveClientContext(@Nonnull final InOutOperationContext operationContext) {
- HttpClientRequestContext requestContext =
+ final HttpClientRequestContext requestContext =
operationContext.getOutboundMessageContext().getSubcontext(HttpClientRequestContext.class);
if (requestContext != null && requestContext.getHttpClientContext() != null) {
return requestContext.getHttpClientContext();
@@ -423,9 +424,9 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
@Nonnull protected CriteriaSet buildTLSCriteriaSet(@Nonnull final HttpUriRequest request,
@Nonnull final InOutOperationContext operationContext) {
- CriteriaSet criteriaSet = new CriteriaSet();
+ final CriteriaSet criteriaSet = new CriteriaSet();
if (getTLSCriteriaSetStrategy() != null) {
- CriteriaSet resolved = getTLSCriteriaSetStrategy().apply(operationContext);
+ final CriteriaSet resolved = getTLSCriteriaSetStrategy().apply(operationContext);
if (resolved != null) {
criteriaSet.addAll(resolved);
}
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
index dd72079..6cdc511 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
@@ -60,7 +60,7 @@ public abstract class AbstractExtensibleSOAPObject extends AbstractXMLObject imp
/** {@inheritDoc} */
@Nullable public List<XMLObject> getOrderedChildren() {
- ArrayList<XMLObject> children = new ArrayList<>();
+ final ArrayList<XMLObject> children = new ArrayList<>();
children.addAll(unknownXMLObjects);
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/SOAP11FaultDecodingException.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/SOAP11FaultDecodingException.java
index e24fec8..90f229b 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/SOAP11FaultDecodingException.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/SOAP11FaultDecodingException.java
@@ -36,7 +36,7 @@ public class SOAP11FaultDecodingException extends MessageDecodingException {
*
* @param soapFault the SOAP 1.1 fault being represented
*/
- public SOAP11FaultDecodingException(Fault soapFault) {
+ public SOAP11FaultDecodingException(final Fault soapFault) {
super();
fault = soapFault;
}
@@ -47,7 +47,7 @@ public class SOAP11FaultDecodingException extends MessageDecodingException {
* @param soapFault the SOAP 1.1 fault being represented
* @param message a textual exception message
*/
- public SOAP11FaultDecodingException(Fault soapFault, String message) {
+ public SOAP11FaultDecodingException(final Fault soapFault, final String message) {
super(message);
fault = soapFault;
}
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
index ea3b9f6..fe3546f 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
@@ -85,7 +85,7 @@ public final class SOAPMessagingSupport {
*/
public static void registerUnderstoodHeader(@Nonnull final MessageContext<? extends XMLObject> msgContext,
@Nonnull final XMLObject header) {
- InboundSOAPContext inboundContext = getInboundSOAPContext(msgContext);
+ final InboundSOAPContext inboundContext = getInboundSOAPContext(msgContext);
inboundContext.getUnderstoodHeaders().add(header);
}
@@ -99,7 +99,7 @@ public final class SOAPMessagingSupport {
*/
public static boolean checkUnderstoodHeader(@Nonnull final MessageContext<? extends XMLObject> msgContext,
@Nonnull final XMLObject header) {
- InboundSOAPContext inboundContext = getInboundSOAPContext(msgContext);
+ final InboundSOAPContext inboundContext = getInboundSOAPContext(msgContext);
return inboundContext.getUnderstoodHeaders().contains(header);
}
@@ -114,7 +114,7 @@ public final class SOAPMessagingSupport {
public static boolean isSOAPMessage(@Nonnull final MessageContext<? extends XMLObject> messageContext) {
Constraint.isNotNull(messageContext, "Message context cannot be null");
- SOAPVersion version = getSOAPVersion(messageContext);
+ final SOAPVersion version = getSOAPVersion(messageContext);
return version != null;
}
@@ -128,7 +128,7 @@ public final class SOAPMessagingSupport {
public static boolean isSOAP11Message(@Nonnull final MessageContext<? extends XMLObject> messageContext) {
Constraint.isNotNull(messageContext, "Message context cannot be null");
- SOAPVersion version = getSOAPVersion(messageContext);
+ final SOAPVersion version = getSOAPVersion(messageContext);
if (version != null && SOAP_1_1.equals(version)) {
return true;
}
@@ -170,7 +170,7 @@ public final class SOAPMessagingSupport {
Constraint.isNotNull(messageContext, "Message context cannot be null");
Constraint.isNotNull(headerBlock, "Header block context cannot be null");
- SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
+ final SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
if (soapVersion == null) {
throw new IllegalArgumentException("Could not determine SOAP version for message context");
}
@@ -197,7 +197,7 @@ public final class SOAPMessagingSupport {
Constraint.isNotNull(messageContext, "Message context cannot be null");
Constraint.isNotNull(headerBlock, "Header block context cannot be null");
- SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
+ final SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
if (soapVersion == null) {
throw new IllegalArgumentException("Could not determine SOAP version for message context");
}
@@ -230,7 +230,7 @@ public final class SOAPMessagingSupport {
Constraint.isNotNull(messageContext, "Message context cannot be null");
Constraint.isNotNull(headerBlock, "Header block context cannot be null");
- SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
+ final SOAPVersion soapVersion = SOAPMessagingSupport.getSOAPVersion(messageContext);
if (soapVersion == null) {
throw new IllegalArgumentException("Could not determine SOAP version for message context");
}
@@ -324,13 +324,13 @@ public final class SOAPMessagingSupport {
Constraint.isNotNull(envelope, "Envelope cannot be null");
Constraint.isNotNull(headerName, "Header name cannot be null");
- Header envelopeHeader = envelope.getHeader();
+ final Header envelopeHeader = envelope.getHeader();
if (envelopeHeader == null) {
return Collections.emptyList();
}
- LazyList<XMLObject> headers = new LazyList<>();
- for (XMLObject header : envelopeHeader.getUnknownXMLObjects(headerName)) {
+ final LazyList<XMLObject> headers = new LazyList<>();
+ for (final XMLObject header : envelopeHeader.getUnknownXMLObjects(headerName)) {
if (isSOAP11HeaderTargetedToNode(header, targetNodes, isFinalDestination)) {
headers.add(header);
}
@@ -351,7 +351,7 @@ public final class SOAPMessagingSupport {
*/
public static boolean isSOAP11HeaderTargetedToNode(@Nonnull final XMLObject header,
@Nullable final Set<String> nodeActors, final boolean isFinalDestination) {
- String headerActor = SOAPSupport.getSOAP11ActorAttribute(header);
+ final String headerActor = SOAPSupport.getSOAP11ActorAttribute(header);
if (headerActor == null) {
if (isFinalDestination) {
return true;
@@ -433,7 +433,7 @@ public final class SOAPMessagingSupport {
* @param fault the fault to register
*/
public static void registerSOAP11Fault(@Nonnull final MessageContext messageContext, @Nullable final Fault fault) {
- SOAP11Context soap11Context = getSOAP11Context(messageContext, true);
+ final SOAP11Context soap11Context = getSOAP11Context(messageContext, true);
soap11Context.setFault(fault);
}
@@ -445,7 +445,7 @@ public final class SOAPMessagingSupport {
* @return the registered fault, or null
*/
public static Fault getSOAP11Fault(@Nonnull final MessageContext messageContext) {
- SOAP11Context soap11Context = getSOAP11Context(messageContext, false);
+ final SOAP11Context soap11Context = getSOAP11Context(messageContext, false);
if (soap11Context != null) {
return soap11Context.getFault();
} else {
@@ -459,7 +459,7 @@ public final class SOAPMessagingSupport {
* @param messageContext the current message context
*/
public static void clearFault(@Nonnull final MessageContext messageContext) {
- SOAP11Context soap11Context = getSOAP11Context(messageContext, false);
+ final SOAP11Context soap11Context = getSOAP11Context(messageContext, false);
if (soap11Context != null) {
soap11Context.setFault(null);
}
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
index 475bfe5..7ff0ab9 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
@@ -93,13 +93,13 @@ public final class SOAPSupport {
*/
public static boolean getSOAP11MustUnderstandAttribute(@Nonnull final XMLObject soapObject) {
if (soapObject instanceof MustUnderstandBearing) {
- XSBooleanValue value = ((MustUnderstandBearing) soapObject).isSOAP11MustUnderstandXSBoolean();
+ final XSBooleanValue value = ((MustUnderstandBearing) soapObject).isSOAP11MustUnderstandXSBoolean();
if (value != null) {
return value.getValue();
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
+ final String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
.getUnknownAttributes().get(MustUnderstandBearing.SOAP11_MUST_UNDERSTAND_ATTR_NAME));
return Objects.equals("1", value) || Objects.equals("true", value);
}
@@ -113,7 +113,8 @@ public final class SOAPSupport {
* @param actorURI the URI of the actor
*/
public static void addSOAP11ActorAttribute(@Nonnull final XMLObject soapObject, @Nonnull final String actorURI) {
- String value = Constraint.isNotNull(StringSupport.trimOrNull(actorURI), "Actor URI cannot be null or empty");
+ final String value =
+ Constraint.isNotNull(StringSupport.trimOrNull(actorURI), "Actor URI cannot be null or empty");
if (soapObject instanceof ActorBearing) {
((ActorBearing) soapObject).setSOAP11Actor(value);
} else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -156,10 +157,10 @@ public final class SOAPSupport {
*/
public static void addSOAP11EncodingStyle(@Nonnull final XMLObject soapObject,
@Nonnull final String encodingStyle) {
- String value = Constraint.isNotNull(StringSupport.trimOrNull(encodingStyle),
+ final String value = Constraint.isNotNull(StringSupport.trimOrNull(encodingStyle),
"Encoding style to add cannot be null or empty");
if (soapObject instanceof EncodingStyleBearing) {
- EncodingStyleBearing esb = (EncodingStyleBearing) soapObject;
+ final EncodingStyleBearing esb = (EncodingStyleBearing) soapObject;
List<String> list = esb.getSOAP11EncodingStyles();
if (list == null) {
list = new LazyList<>();
@@ -167,7 +168,7 @@ public final class SOAPSupport {
}
list.add(value);
} else if (soapObject instanceof AttributeExtensibleXMLObject) {
- AttributeMap am = ((AttributeExtensibleXMLObject) soapObject).getUnknownAttributes();
+ final AttributeMap am = ((AttributeExtensibleXMLObject) soapObject).getUnknownAttributes();
String list = am.get(EncodingStyleBearing.SOAP11_ENCODING_STYLE_ATTR_NAME);
if (list == null) {
list = value;
@@ -212,13 +213,13 @@ public final class SOAPSupport {
*/
@Nullable public static List<String> getSOAP11EncodingStyles(@Nonnull final XMLObject soapObject) {
if (soapObject instanceof EncodingStyleBearing) {
- List<String> value = ((EncodingStyleBearing) soapObject).getSOAP11EncodingStyles();
+ final List<String> value = ((EncodingStyleBearing) soapObject).getSOAP11EncodingStyles();
if (value != null) {
return value;
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
+ final String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
.getUnknownAttributes().get(EncodingStyleBearing.SOAP11_ENCODING_STYLE_ATTR_NAME));
if (value != null) {
StringSupport.stringToList(value, XMLConstants.LIST_DELIMITERS);
@@ -235,7 +236,7 @@ public final class SOAPSupport {
*/
public static void addSOAP12EncodingStyleAttribute(@Nonnull final XMLObject soapObject,
@Nonnull final String style) {
- String value = Constraint.isNotNull(StringSupport.trimOrNull(style),
+ final String value = Constraint.isNotNull(StringSupport.trimOrNull(style),
"Encoding style to add cannot be null or empty");
if (soapObject instanceof org.opensaml.soap.soap12.EncodingStyleBearing) {
@@ -301,14 +302,14 @@ public final class SOAPSupport {
*/
public static boolean getSOAP12MustUnderstandAttribute(@Nonnull final XMLObject soapObject) {
if (soapObject instanceof org.opensaml.soap.soap12.MustUnderstandBearing) {
- XSBooleanValue value = ((org.opensaml.soap.soap12.MustUnderstandBearing) soapObject)
+ final XSBooleanValue value = ((org.opensaml.soap.soap12.MustUnderstandBearing) soapObject)
.isSOAP12MustUnderstandXSBoolean();
if (value != null) {
return value.getValue();
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
+ final String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
.getUnknownAttributes().get(
org.opensaml.soap.soap12.MustUnderstandBearing.SOAP12_MUST_UNDERSTAND_ATTR_NAME));
return Objects.equals("1", value) || Objects.equals("true", value);
@@ -343,13 +344,13 @@ public final class SOAPSupport {
*/
public static boolean getSOAP12RelayAttribute(@Nonnull final XMLObject soapObject) {
if (soapObject instanceof org.opensaml.soap.soap12.RelayBearing) {
- XSBooleanValue value = ((org.opensaml.soap.soap12.RelayBearing) soapObject).isSOAP12RelayXSBoolean();
+ final XSBooleanValue value = ((org.opensaml.soap.soap12.RelayBearing) soapObject).isSOAP12RelayXSBoolean();
if (value != null) {
return value.getValue();
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
+ final String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject) soapObject)
.getUnknownAttributes().get(org.opensaml.soap.soap12.RelayBearing.SOAP12_RELAY_ATTR_LOCAL_NAME));
return Objects.equals("1", value) || Objects.equals("true", value);
}
@@ -363,7 +364,7 @@ public final class SOAPSupport {
* @param role the role
*/
public static void addSOAP12RoleAttribute(@Nonnull final XMLObject soapObject, @Nonnull final String role) {
- String value = Constraint.isNotNull(StringSupport.trimOrNull(role), "Role cannot be null or empty");
+ final String value = Constraint.isNotNull(StringSupport.trimOrNull(role), "Role cannot be null or empty");
if (soapObject instanceof org.opensaml.soap.soap12.RoleBearing) {
((org.opensaml.soap.soap12.RoleBearing) soapObject).setSOAP12Role(value);
@@ -508,7 +509,7 @@ public final class SOAPSupport {
Constraint.isNotNull(faultCode, "faultcode cannot be null");
Constraint.isNotNull(faultString, "faultstring cannot be null");
- XMLObjectBuilderFactory builderFactory = XMLObjectProviderRegistrySupport.getBuilderFactory();
+ final XMLObjectBuilderFactory builderFactory = XMLObjectProviderRegistrySupport.getBuilderFactory();
final Fault faultObj = (Fault) builderFactory.getBuilder(Fault.DEFAULT_ELEMENT_NAME)
.buildObject(Fault.DEFAULT_ELEMENT_NAME);
@@ -534,7 +535,7 @@ public final class SOAPSupport {
if (detailChildren != null && !detailChildren.isEmpty()) {
detailObj = (Detail) builderFactory.getBuilder(Detail.DEFAULT_ELEMENT_NAME)
.buildObject(Detail.DEFAULT_ELEMENT_NAME);
- for (XMLObject xo : Iterables.filter(detailChildren, Predicates.notNull())) {
+ for (final XMLObject xo : Iterables.filter(detailChildren, Predicates.notNull())) {
detailObj.getUnknownXMLObjects().add(xo);
}
}
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
index 375a956..b5ed9b3 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
@@ -66,13 +66,13 @@ public final class WSAddressingSupport {
*/
public static boolean getWSAIsReferenceParameter(final XMLObject soapObject) {
if (soapObject instanceof IsReferenceParameterBearing) {
- XSBooleanValue value = ((IsReferenceParameterBearing)soapObject).isWSAIsReferenceParameterXSBoolean();
+ final XSBooleanValue value = ((IsReferenceParameterBearing)soapObject).isWSAIsReferenceParameterXSBoolean();
if (value != null) {
return value.getValue();
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String valueStr = StringSupport.trimOrNull(((AttributeExtensibleXMLObject)soapObject)
+ final String valueStr = StringSupport.trimOrNull(((AttributeExtensibleXMLObject)soapObject)
.getUnknownAttributes().get(IsReferenceParameterBearing.WSA_IS_REFERENCE_PARAMETER_ATTR_NAME));
return Objects.equals("1", valueStr) || Objects.equals("true", valueStr);
}
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
index c4764cc..396d53e 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
@@ -74,14 +74,15 @@ public final class WSSecurityMessagingSupport {
Constraint.isNotNull(messageContext, "Message context cannot be null");
Constraint.isNotNull(securitySubHeader, "Security sub-header context cannot be null");
- List<XMLObject> securityHeaders = SOAPMessagingSupport.getHeaderBlock(messageContext, Security.ELEMENT_NAME,
+ final List<XMLObject> securityHeaders =
+ SOAPMessagingSupport.getHeaderBlock(messageContext, Security.ELEMENT_NAME,
targetNode != null ? Collections.singleton(targetNode) : null,
isFinalDestination);
Security security = null;
- for (XMLObject header : securityHeaders) {
- Security candidate = (Security) header;
- boolean candidateMustUnderstand = SOAPMessagingSupport.isMustUnderstand(messageContext, candidate);
+ for (final XMLObject header : securityHeaders) {
+ final Security candidate = (Security) header;
+ final boolean candidateMustUnderstand = SOAPMessagingSupport.isMustUnderstand(messageContext, candidate);
if (mustUnderstand == candidateMustUnderstand) {
security = candidate;
break;
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
index 5963caa..3dd1d30 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
@@ -130,7 +130,7 @@ public final class WSSecuritySupport {
*/
public static void addWSSEUsage(final XMLObject soapObject, final String usage) {
if (soapObject instanceof UsageBearing) {
- UsageBearing usageBearing = (UsageBearing) soapObject;
+ final UsageBearing usageBearing = (UsageBearing) soapObject;
List<String> list = usageBearing.getWSSEUsages();
if (list == null) {
list = new LazyList<>();
@@ -138,7 +138,7 @@ public final class WSSecuritySupport {
}
list.add(usage);
} else if (soapObject instanceof AttributeExtensibleXMLObject) {
- AttributeMap am = ((AttributeExtensibleXMLObject)soapObject).getUnknownAttributes();
+ final AttributeMap am = ((AttributeExtensibleXMLObject)soapObject).getUnknownAttributes();
String list = am.get(UsageBearing.WSSE_USAGE_ATTR_NAME);
if (list == null) {
list = usage;
@@ -178,13 +178,13 @@ public final class WSSecuritySupport {
*/
public static List<String> getWSSEUsages(final XMLObject soapObject) {
if (soapObject instanceof UsageBearing) {
- List<String> value = ((UsageBearing)soapObject).getWSSEUsages();
+ final List<String> value = ((UsageBearing)soapObject).getWSSEUsages();
if (value != null) {
return value;
}
}
if (soapObject instanceof AttributeExtensibleXMLObject) {
- String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject)soapObject)
+ final String value = StringSupport.trimOrNull(((AttributeExtensibleXMLObject)soapObject)
.getUnknownAttributes().get(UsageBearing.WSSE_USAGE_ATTR_NAME));
if (value != null) {
StringSupport.stringToList(value, XMLConstants.LIST_DELIMITERS);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list