[java-opensaml] 01/04: JPAR-85 - Checkstyle, check final parameters

Tom Zeller tzeller at dragonacea.biz
Wed Aug 9 23:27:09 EDT 2017


This is an automated email from the git hooks/post-receive script.

tzeller pushed a commit to branch master
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=48654bf1d5cbe42e2e634fe5a92ef0e4b5c33f84

commit 48654bf1d5cbe42e2e634fe5a92ef0e4b5c33f84
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Wed Aug 9 21:52:19 2017 -0500

    JPAR-85 - Checkstyle, check final parameters
---
 .../client/http/AbstractPipelineHttpSOAPClient.java  | 20 ++++++++++----------
 .../opensaml/soap/client/http/HttpSOAPClient.java    |  2 +-
 .../client/http/PipelineFactoryHttpSOAPClient.java   |  6 +++---
 .../soap/common/AbstractExtensibleSOAPObject.java    |  2 +-
 .../soap/messaging/SOAPMessagingSupport.java         | 13 +++++++------
 .../soap/messaging/context/InboundSOAPContext.java   |  2 +-
 .../java/org/opensaml/soap/util/SOAPSupport.java     | 15 +++++++++------
 .../wsaddressing/messaging/WSAddressingContext.java  | 10 +++++-----
 .../soap/wsaddressing/util/WSAddressingSupport.java  |  4 ++--
 .../messaging/WSSecurityMessagingSupport.java        |  6 +++---
 .../soap/wssecurity/util/WSSecuritySupport.java      | 14 +++++++-------
 11 files changed, 49 insertions(+), 45 deletions(-)

diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
index 4cb4ac5..63288fd 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/AbstractPipelineHttpSOAPClient.java
@@ -228,23 +228,23 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
                 pipeline.getInboundMessageHandler().invoke(operationContext.getInboundMessageContext());
             }
             
-        } catch (SOAP11FaultDecodingException e) {
+        } catch (final SOAP11FaultDecodingException e) {
             SOAPFaultException faultException = new SOAPFaultException(e.getMessage(), e);
             faultException.setFault(e.getFault());
             throw faultException;
-        } catch (SSLException e) {
+        } catch (final SSLException e) {
             throw new SecurityException("Problem establising TLS connection to: " + endpoint, e);
-        } catch (ComponentInitializationException e) {
+        } catch (final ComponentInitializationException e) {
             throw new SOAPException("Problem initializing a SOAP client component", e);
-        } catch (MessageEncodingException e) {
+        } catch (final MessageEncodingException e) {
             throw new SOAPException("Problem encoding SOAP request message to: " + endpoint, e);
-        } catch (MessageDecodingException e) {
+        } catch (final MessageDecodingException e) {
             throw new SOAPException("Problem decoding SOAP response message from: " + endpoint, e);
-        } catch (MessageHandlerException e) {
+        } catch (final MessageHandlerException e) {
             throw new SOAPException("Problem handling SOAP message exchange with: " + endpoint, e);
-        } catch (ClientProtocolException e) {
+        } catch (final ClientProtocolException e) {
             throw new SOAPException("Client protocol problem sending SOAP request message to: " + endpoint, e);
-        } catch (IOException e) {
+        } catch (final IOException e) {
             throw new SOAPException("I/O problem with SOAP message exchange with: " + endpoint, e);
         } finally {
             if (pipeline != null) {
@@ -276,10 +276,10 @@ public abstract class AbstractPipelineHttpSOAPClient<OutboundMessageType, Inboun
             resolvePipeline(@Nonnull final InOutOperationContext operationContext) throws SOAPException {
         try {
             return newPipeline();
-        } catch (SOAPException e) {
+        } catch (final SOAPException e) {
             log.warn("Problem resolving pipeline instance", e);
             throw e;
-        } catch (Exception e) {
+        } catch (final Exception e) {
             // This is to handle RuntimeExceptions, for example thrown by Spring dynamic factory approaches
             log.warn("Problem resolving pipeline instance", e);
             throw new SOAPException("Could not resolve pipeline", e);
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
index 529ba99..aad6056 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/HttpSOAPClient.java
@@ -396,7 +396,7 @@ public class HttpSOAPClient extends AbstractInitializableComponent implements SO
      * 
      * @throws SOAPClientException thrown if there is a problem resolving or evaluating a security policy
      */
-    protected void evaluateSecurityPolicy(SOAPClientContext messageContext) throws SOAPClientException {
+    protected void evaluateSecurityPolicy(final SOAPClientContext messageContext) throws SOAPClientException {
         //TODO: I think this goes away, with the policy layer living outside the client?
         /*
         SecurityPolicyResolver policyResolver = messageContext.getSecurityPolicyResolver();
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/PipelineFactoryHttpSOAPClient.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/PipelineFactoryHttpSOAPClient.java
index 9b85750..96d2904 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/PipelineFactoryHttpSOAPClient.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/client/http/PipelineFactoryHttpSOAPClient.java
@@ -117,7 +117,7 @@ public class PipelineFactoryHttpSOAPClient<OutboundMessageType, InboundMessageTy
      * @throws SOAPException if there is an error obtaining a new pipeline instance
      */
     @Nonnull protected HttpClientMessagePipeline<InboundMessageType, OutboundMessageType> 
-            resolvePipeline(InOutOperationContext operationContext) throws SOAPException {
+            resolvePipeline(final InOutOperationContext operationContext) throws SOAPException {
         
         String resolvedPipelineName = null;
         try {
@@ -128,10 +128,10 @@ public class PipelineFactoryHttpSOAPClient<OutboundMessageType, InboundMessageTy
             } else {
                 return newPipeline();
             }
-        } catch (SOAPException e) {
+        } catch (final SOAPException e) {
             log.warn("Problem resolving pipeline instance with name: {}", resolvedPipelineName, e);
             throw e;
-        } catch (Exception e) {
+        } catch (final Exception e) {
             // This is to handle RuntimeExceptions, for example thrown by Spring dynamic factory approaches
             log.warn("Problem resolving pipeline instance with name: {}", resolvedPipelineName, e);
             throw new SOAPException("Could not resolve pipeline with name: " + resolvedPipelineName, e);
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
index 172a1bb..dd72079 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/common/AbstractExtensibleSOAPObject.java
@@ -73,7 +73,7 @@ public abstract class AbstractExtensibleSOAPObject extends AbstractXMLObject imp
     }
     
     /** {@inheritDoc} */
-    @Nonnull public List<XMLObject> getUnknownXMLObjects(QName typeOrName) {
+    @Nonnull public List<XMLObject> getUnknownXMLObjects(final QName typeOrName) {
         return (List<XMLObject>) unknownXMLObjects.subList(typeOrName);
     }
 
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
index fdd05b8..ea3b9f6 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/SOAPMessagingSupport.java
@@ -72,7 +72,7 @@ public final class SOAPMessagingSupport {
      * @return the current SOAP 1.1 context. May be null if autoCreate=false, otherwise will be non-null
      */
     @Nullable public static SOAP11Context getSOAP11Context(@Nonnull final MessageContext messageContext,
-            boolean autoCreate) {
+            final boolean autoCreate) {
         Constraint.isNotNull(messageContext, "Message context cannot be null");
         return messageContext.getSubcontext(SOAP11Context.class, autoCreate);
     }
@@ -193,7 +193,7 @@ public final class SOAPMessagingSupport {
      * @param mustUnderstand true if header must be understood, false if not
      */
     public static void addMustUnderstand(@Nonnull final MessageContext messageContext,
-            @Nonnull final XMLObject headerBlock, boolean mustUnderstand) {
+            @Nonnull final XMLObject headerBlock, final boolean mustUnderstand) {
         Constraint.isNotNull(messageContext, "Message context cannot be null");
         Constraint.isNotNull(headerBlock, "Header block context cannot be null");
         
@@ -223,7 +223,7 @@ public final class SOAPMessagingSupport {
      * @param targetNode the node to add
      */
     public static void addTargetNode(@Nonnull final MessageContext messageContext,
-            @Nonnull final XMLObject headerBlock, @Nullable String targetNode) {
+            @Nonnull final XMLObject headerBlock, @Nullable final String targetNode) {
         if (targetNode == null) {
             return;
         }
@@ -294,7 +294,7 @@ public final class SOAPMessagingSupport {
      */
     @Nonnull public static List<XMLObject> getHeaderBlock(
             @Nonnull final MessageContext messageContext, @Nonnull final QName headerName,
-            @Nullable Set<String> targetNodes, boolean isFinalDestination) {
+            @Nullable final Set<String> targetNodes, final boolean isFinalDestination) {
         Constraint.isNotNull(messageContext, "Message context cannot be null");
         
         final SOAP11Context soap11 = getSOAP11Context(messageContext, false);
@@ -319,7 +319,8 @@ public final class SOAPMessagingSupport {
      * @return the list of matching header blocks
      */
     @Nonnull public static List<XMLObject> getSOAP11HeaderBlock(@Nonnull final Envelope envelope,
-            @Nonnull final QName headerName, @Nullable final Set<String> targetNodes, boolean isFinalDestination) {
+            @Nonnull final QName headerName, @Nullable final Set<String> targetNodes,
+            final boolean isFinalDestination) {
         Constraint.isNotNull(envelope, "Envelope cannot be null");
         Constraint.isNotNull(headerName, "Header name cannot be null");
         
@@ -349,7 +350,7 @@ public final class SOAPMessagingSupport {
      * @return the list of matching header blocks
      */
     public static boolean isSOAP11HeaderTargetedToNode(@Nonnull final XMLObject header,
-            @Nullable final Set<String> nodeActors, boolean isFinalDestination) {
+            @Nullable final Set<String> nodeActors, final boolean isFinalDestination) {
         String headerActor = SOAPSupport.getSOAP11ActorAttribute(header);
         if (headerActor == null) {
             if (isFinalDestination) {
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/context/InboundSOAPContext.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/context/InboundSOAPContext.java
index 52d3cef..b0327f6 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/context/InboundSOAPContext.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/messaging/context/InboundSOAPContext.java
@@ -93,7 +93,7 @@ public class InboundSOAPContext extends BaseContext {
      * @param newValue the new flag value
      * 
      */
-    public void setFinalDestination(boolean newValue) {
+    public void setFinalDestination(final boolean newValue) {
         finalDestination = newValue;
     }
 
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
index 0b400b3..475bfe5 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/util/SOAPSupport.java
@@ -70,7 +70,8 @@ public final class SOAPSupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param mustUnderstand whether mustUnderstand is true or false
      */
-    public static void addSOAP11MustUnderstandAttribute(@Nonnull final XMLObject soapObject, boolean mustUnderstand) {
+    public static void addSOAP11MustUnderstandAttribute(@Nonnull final XMLObject soapObject,
+            final boolean mustUnderstand) {
         if (soapObject instanceof MustUnderstandBearing) {
             ((MustUnderstandBearing) soapObject).setSOAP11MustUnderstand(new XSBooleanValue(mustUnderstand, true));
         } else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -276,7 +277,8 @@ public final class SOAPSupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param mustUnderstand whether mustUnderstand is true or false
      */
-    public static void addSOAP12MustUnderstandAttribute(@Nonnull final XMLObject soapObject, boolean mustUnderstand) {
+    public static void addSOAP12MustUnderstandAttribute(@Nonnull final XMLObject soapObject,
+            final boolean mustUnderstand) {
         if (soapObject instanceof org.opensaml.soap.soap12.MustUnderstandBearing) {
             ((org.opensaml.soap.soap12.MustUnderstandBearing) soapObject)
                     .setSOAP12MustUnderstand(new XSBooleanValue(mustUnderstand, false));
@@ -320,7 +322,7 @@ public final class SOAPSupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param relay whether relay is true or false
      */
-    public static void addSOAP12RelayAttribute(@Nonnull final XMLObject soapObject, boolean relay) {
+    public static void addSOAP12RelayAttribute(@Nonnull final XMLObject soapObject, final boolean relay) {
         if (soapObject instanceof org.opensaml.soap.soap12.RelayBearing) {
             ((org.opensaml.soap.soap12.RelayBearing) soapObject).setSOAP12Relay(new XSBooleanValue(relay, false));
         } else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -437,7 +439,7 @@ public final class SOAPSupport {
      */
     @Nonnull public static List<XMLObject> getInboundHeaderBlock(
             @Nonnull final MessageContext messageContext, @Nonnull final QName headerName,
-            @Nullable Set<String> targetNodes, boolean isFinalDestination) {
+            @Nullable final Set<String> targetNodes, final boolean isFinalDestination) {
         return SOAPMessagingSupport.getHeaderBlock(messageContext, headerName, targetNodes, isFinalDestination);
     }
 
@@ -454,7 +456,8 @@ public final class SOAPSupport {
      * @deprecated use {@link SOAPMessagingSupport#getSOAP11HeaderBlock(Envelope, QName, Set, boolean)}
      */
     @Nonnull public static List<XMLObject> getSOAP11HeaderBlock(@Nonnull final Envelope envelope,
-            @Nonnull final QName headerName, @Nullable final Set<String> targetNodes, boolean isFinalDestination) {
+            @Nonnull final QName headerName, @Nullable final Set<String> targetNodes,
+            final boolean isFinalDestination) {
         return SOAPMessagingSupport.getSOAP11HeaderBlock(envelope, headerName, targetNodes, isFinalDestination);
     }
     
@@ -471,7 +474,7 @@ public final class SOAPSupport {
      * @deprecated use {@link SOAPMessagingSupport#isSOAP11HeaderTargetedToNode(XMLObject, Set, boolean)}
      */
     public static boolean isSOAP11HeaderTargetedToNode(@Nonnull final XMLObject header,
-            @Nullable final Set<String> nodeActors, boolean isFinalDestination) {
+            @Nullable final Set<String> nodeActors, final boolean isFinalDestination) {
         return SOAPMessagingSupport.isSOAP11HeaderTargetedToNode(header, nodeActors, isFinalDestination);
     }
 
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/messaging/WSAddressingContext.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/messaging/WSAddressingContext.java
index 2d4d21b..95748df 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/messaging/WSAddressingContext.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/messaging/WSAddressingContext.java
@@ -57,7 +57,7 @@ public class WSAddressingContext extends BaseContext {
      * 
      * @param uri the new Action URI value
      */
-    public void setActionURI(String uri) {
+    public void setActionURI(final String uri) {
         actionURI = StringSupport.trimOrNull(uri);
     }
     
@@ -75,7 +75,7 @@ public class WSAddressingContext extends BaseContext {
      * 
      * @param uri the new Fault Action URI value
      */
-    public void setFaultActionURI(String uri) {
+    public void setFaultActionURI(final String uri) {
         faultActionURI = StringSupport.trimOrNull(uri);
     }
     
@@ -93,7 +93,7 @@ public class WSAddressingContext extends BaseContext {
      * 
      * @param uri the new MessageID URI value
      */
-    public void setMessageIDURI(String uri) {
+    public void setMessageIDURI(final String uri) {
         messageIDURI = StringSupport.trimOrNull(uri);
     }
 
@@ -111,7 +111,7 @@ public class WSAddressingContext extends BaseContext {
      * 
      * @param uri the RelatesTo URI value
      */
-    public void setRelatesToURI(String uri) {
+    public void setRelatesToURI(final String uri) {
         relatesToURI = StringSupport.trimOrNull(uri);
     }
 
@@ -129,7 +129,7 @@ public class WSAddressingContext extends BaseContext {
      * 
      * @param value the RelatesTo RelationshipType attribute value
      */
-    public void setRelatesToRelationshipType(String value) {
+    public void setRelatesToRelationshipType(final String value) {
         relatesToRelationshipType = StringSupport.trimOrNull(value);
     }
 
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
index 77aa265..375a956 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wsaddressing/util/WSAddressingSupport.java
@@ -43,7 +43,7 @@ public final class WSAddressingSupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param isReferenceParameter whether IsReferenceParameter is true or false
      */
-    public static void addWSAIsReferenceParameter(XMLObject soapObject, boolean isReferenceParameter) {
+    public static void addWSAIsReferenceParameter(final XMLObject soapObject, final boolean isReferenceParameter) {
         if (soapObject instanceof IsReferenceParameterBearing) {
             ((IsReferenceParameterBearing)soapObject).setWSAIsReferenceParameter(
                     new XSBooleanValue(isReferenceParameter, false));
@@ -64,7 +64,7 @@ public final class WSAddressingSupport {
      * 
      * @return value of the IsReferenceParameter attribute, or false if not present
      */
-    public static boolean getWSAIsReferenceParameter(XMLObject soapObject) {
+    public static boolean getWSAIsReferenceParameter(final XMLObject soapObject) {
         if (soapObject instanceof IsReferenceParameterBearing) {
             XSBooleanValue value = ((IsReferenceParameterBearing)soapObject).isWSAIsReferenceParameterXSBoolean();
             if (value != null) {
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
index 8155fb0..c4764cc 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/messaging/WSSecurityMessagingSupport.java
@@ -52,7 +52,7 @@ public final class WSSecurityMessagingSupport {
      *          that it must be understood
      */
     public static void addSecurityHeaderBlock(@Nonnull final MessageContext messageContext,
-            @Nonnull final XMLObject securityHeader, boolean mustUnderstand) {
+            @Nonnull final XMLObject securityHeader, final boolean mustUnderstand) {
         addSecurityHeaderBlock(messageContext, securityHeader, mustUnderstand, null, true);
     }
     
@@ -69,8 +69,8 @@ public final class WSSecurityMessagingSupport {
      *          false specifies they should not be returned
      */
     public static void addSecurityHeaderBlock(@Nonnull final MessageContext messageContext,
-            @Nonnull final XMLObject securitySubHeader, boolean mustUnderstand, 
-            @Nullable final String targetNode, boolean isFinalDestination) {
+            @Nonnull final XMLObject securitySubHeader, final boolean mustUnderstand, 
+            @Nullable final String targetNode, final boolean isFinalDestination) {
         Constraint.isNotNull(messageContext, "Message context cannot be null");
         Constraint.isNotNull(securitySubHeader, "Security sub-header context cannot be null");
 
diff --git a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
index 897eb62..5963caa 100644
--- a/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
+++ b/opensaml-soap-api/src/main/java/org/opensaml/soap/wssecurity/util/WSSecuritySupport.java
@@ -47,7 +47,7 @@ public final class WSSecuritySupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param id the Id value
      */
-    public static void addWSUId(XMLObject soapObject, String id) {
+    public static void addWSUId(final XMLObject soapObject, final String id) {
         if (soapObject instanceof IdBearing) {
             ((IdBearing)soapObject).setWSUId(id);
         } else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -65,7 +65,7 @@ public final class WSSecuritySupport {
      * 
      * @return the value of the Id attribute, or null if not present
      */
-    public static String getWSUId(XMLObject soapObject) {
+    public static String getWSUId(final XMLObject soapObject) {
         String value = null;
         if (soapObject instanceof IdBearing) {
             value = StringSupport.trimOrNull(((IdBearing)soapObject).getWSUId());
@@ -87,7 +87,7 @@ public final class WSSecuritySupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param tokenType the tokenType value
      */
-    public static void addWSSE11TokenType(XMLObject soapObject, String tokenType) {
+    public static void addWSSE11TokenType(final XMLObject soapObject, final String tokenType) {
         if (soapObject instanceof TokenTypeBearing) {
             ((TokenTypeBearing)soapObject).setWSSE11TokenType(tokenType);
         } else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -105,7 +105,7 @@ public final class WSSecuritySupport {
      * 
      * @return the value of the tokenType attribute, or null if not present
      */
-    public static String getWSSE11TokenType(XMLObject soapObject) {
+    public static String getWSSE11TokenType(final XMLObject soapObject) {
         String value = null;
         if (soapObject instanceof TokenTypeBearing) {
             value = StringSupport.trimOrNull(((TokenTypeBearing)soapObject).getWSSE11TokenType());
@@ -128,7 +128,7 @@ public final class WSSecuritySupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param usage the usage to add
      */
-    public static void addWSSEUsage(XMLObject soapObject, String usage) {
+    public static void addWSSEUsage(final XMLObject soapObject, final String usage) {
         if (soapObject instanceof UsageBearing) {
             UsageBearing usageBearing = (UsageBearing) soapObject;
             List<String> list = usageBearing.getWSSEUsages();
@@ -157,7 +157,7 @@ public final class WSSecuritySupport {
      * @param soapObject the SOAP object to add the attribute to
      * @param usages the list of usages to add
      */
-    public static void addWSSEUsages(XMLObject soapObject, List<String> usages) {
+    public static void addWSSEUsages(final XMLObject soapObject, final List<String> usages) {
         if (soapObject instanceof UsageBearing) {
             ((UsageBearing)soapObject).setWSSEUsages(usages);
         } else if (soapObject instanceof AttributeExtensibleXMLObject) {
@@ -176,7 +176,7 @@ public final class WSSecuritySupport {
      * 
      * @return the list of usages, or null if not present
      */
-    public static List<String> getWSSEUsages(XMLObject soapObject) {
+    public static List<String> getWSSEUsages(final XMLObject soapObject) {
         if (soapObject instanceof UsageBearing) {
             List<String> value = ((UsageBearing)soapObject).getWSSEUsages();
             if (value != null) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list