[java-opensaml] 02/04: JPAR-85 - Checkstyle, check final variables
Tom Zeller
tzeller at dragonacea.biz
Mon Aug 7 16:51:55 EDT 2017
This is an automated email from the git hooks/post-receive script.
tzeller pushed a commit to branch master
in repository java-opensaml.
View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=7ee1b2d226f80a610d9d65bace57c7f26d33fa7a
commit 7ee1b2d226f80a610d9d65bace57c7f26d33fa7a
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Mon Aug 7 15:49:30 2017 -0500
JPAR-85 - Checkstyle, check final variables
---
.../src/main/java/org/opensaml/messaging/context/BaseContext.java | 4 ++--
.../decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java | 6 +++---
.../decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java | 6 +++---
.../encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java | 4 ++--
.../encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java | 4 ++--
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
index 973c09d..429d5a0 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
@@ -267,7 +267,7 @@ public abstract class BaseContext implements Iterable<BaseContext> {
*/
public void clearSubcontexts() {
log.trace("Clearing all subcontexts from context with type '{}'", this.getClass().getName());
- for (BaseContext subcontext : subcontexts) {
+ for (final BaseContext subcontext : subcontexts) {
subcontext.setParent(null);
}
subcontexts.clear();
@@ -305,7 +305,7 @@ public abstract class BaseContext implements Iterable<BaseContext> {
* @return the new subcontext instance
*/
@Nonnull protected <T extends BaseContext> T createSubcontext(@Nonnull final Class<T> clazz) {
- Constructor<T> constructor;
+ final Constructor<T> constructor;
try {
constructor = clazz.getConstructor();
return constructor.newInstance();
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
index 074ce42..ca639ec 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
@@ -111,14 +111,14 @@ public abstract class BaseHttpClientResponseXMLMessageDecoder<MessageType extend
*/
protected void logDecodedMessage() {
if (protocolMessageLog.isDebugEnabled() ){
- XMLObject message = getMessageToLog();
+ final XMLObject message = getMessageToLog();
if (message == null) {
log.warn("Decoded message was null, nothing to log");
return;
}
try {
- Element dom = XMLObjectSupport.marshall(message);
+ final Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
} catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
@@ -146,7 +146,7 @@ public abstract class BaseHttpClientResponseXMLMessageDecoder<MessageType extend
*/
protected XMLObject unmarshallMessage(final InputStream messageStream) throws MessageDecodingException {
try {
- XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
+ final XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
return message;
} catch (final XMLParserException e) {
log.error("Error unmarshalling message from input stream", e);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
index f4c83ce..5b6c017 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
@@ -116,14 +116,14 @@ public abstract class BaseHttpServletRequestXMLMessageDecoder<MessageType extend
*/
protected void logDecodedMessage() {
if (protocolMessageLog.isDebugEnabled() ){
- XMLObject message = getMessageToLog();
+ final XMLObject message = getMessageToLog();
if (message == null) {
log.warn("Decoded message was null, nothing to log");
return;
}
try {
- Element dom = XMLObjectSupport.marshall(message);
+ final Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
} catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
@@ -151,7 +151,7 @@ public abstract class BaseHttpServletRequestXMLMessageDecoder<MessageType extend
*/
protected XMLObject unmarshallMessage(final InputStream messageStream) throws MessageDecodingException {
try {
- XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
+ final XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
return message;
} catch (final XMLParserException e) {
log.error("Error unmarshalling message from input stream", e);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
index 7d08b6f..3f54eda 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
@@ -59,14 +59,14 @@ public abstract class BaseHttpClientRequestXMLMessageEncoder<MessageType extends
*/
protected void logEncodedMessage() {
if (protocolMessageLog.isDebugEnabled() ){
- XMLObject message = getMessageToLog();
+ final XMLObject message = getMessageToLog();
if (message == null) {
log.warn("Encoded message was null, nothing to log");
return;
}
try {
- Element dom = XMLObjectSupport.marshall(message);
+ final Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
} catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
index 4e5b14b..a835297 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
@@ -59,14 +59,14 @@ public abstract class BaseHttpServletResponseXMLMessageEncoder<MessageType exten
*/
protected void logEncodedMessage() {
if (protocolMessageLog.isDebugEnabled() ){
- XMLObject message = getMessageToLog();
+ final XMLObject message = getMessageToLog();
if (message == null) {
log.warn("Encoded message was null, nothing to log");
return;
}
try {
- Element dom = XMLObjectSupport.marshall(message);
+ final Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
} catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list