[java-opensaml] 01/04: JPAR-85 - Checkstyle, check final parameters
Tom Zeller
tzeller at dragonacea.biz
Mon Aug 7 16:51:54 EDT 2017
This is an automated email from the git hooks/post-receive script.
tzeller pushed a commit to branch master
in repository java-opensaml.
View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=3eba45851ff5cf2a28ad189dabaed1673c253a64
commit 3eba45851ff5cf2a28ad189dabaed1673c253a64
Author: Tom Zeller <tzeller at dragonacea.biz>
AuthorDate: Mon Aug 7 15:48:10 2017 -0500
JPAR-85 - Checkstyle, check final parameters
---
.../src/main/java/org/opensaml/messaging/context/BaseContext.java | 2 +-
.../org/opensaml/messaging/context/InOutOperationContext.java | 8 ++++----
.../opensaml/messaging/context/MessageChannelSecurityContext.java | 4 ++--
.../main/java/org/opensaml/messaging/context/MessageContext.java | 2 +-
.../org/opensaml/messaging/decoder/AbstractMessageDecoder.java | 2 +-
.../httpclient/BaseHttpClientResponseXMLMessageDecoder.java | 8 ++++----
.../decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java | 8 ++++----
.../org/opensaml/messaging/encoder/AbstractMessageEncoder.java | 2 +-
.../httpclient/BaseHttpClientRequestXMLMessageEncoder.java | 6 +++---
.../encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java | 6 +++---
.../org/opensaml/messaging/handler/AbstractMessageHandler.java | 8 ++++----
.../org/opensaml/messaging/pipeline/BasicMessagePipeline.java | 4 ++--
.../opensaml/messaging/pipeline/StaticPipelineNameStrategy.java | 2 +-
.../pipeline/httpclient/BasicHttpClientMessagePipeline.java | 4 ++--
.../pipeline/servlet/BasicHttpServletMessagePipeline.java | 4 ++--
15 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
index d6d98bf..973c09d 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/BaseContext.java
@@ -343,7 +343,7 @@ public abstract class BaseContext implements Iterable<BaseContext> {
*
* @param iterator the iterator instance to decorator
*/
- protected ContextSetNoRemoveIteratorDecorator(Iterator<BaseContext> iterator) {
+ protected ContextSetNoRemoveIteratorDecorator(final Iterator<BaseContext> iterator) {
wrappedIterator = iterator;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/InOutOperationContext.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/InOutOperationContext.java
index be737b3..08308b9 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/InOutOperationContext.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/InOutOperationContext.java
@@ -45,8 +45,8 @@ public class InOutOperationContext<InboundMessageType, OutboundMessageType> exte
* @param inbound the inbound message context
* @param outbound the outbound message context
*/
- public InOutOperationContext(MessageContext<InboundMessageType> inbound,
- MessageContext<OutboundMessageType> outbound) {
+ public InOutOperationContext(final MessageContext<InboundMessageType> inbound,
+ final MessageContext<OutboundMessageType> outbound) {
this();
setInboundMessageContext(inbound);
@@ -68,7 +68,7 @@ public class InOutOperationContext<InboundMessageType, OutboundMessageType> exte
*
* @param context inbound message context, may be null
*/
- public void setInboundMessageContext(MessageContext<InboundMessageType> context) {
+ public void setInboundMessageContext(final MessageContext<InboundMessageType> context) {
// Unlink the old context from this parent
if (inboundContext != null) {
inboundContext.setParent(null);
@@ -96,7 +96,7 @@ public class InOutOperationContext<InboundMessageType, OutboundMessageType> exte
*
* @param context outbound message context, may be null
*/
- public void setOutboundMessageContext(MessageContext<OutboundMessageType> context) {
+ public void setOutboundMessageContext(final MessageContext<OutboundMessageType> context) {
// Unlink the old context from this parent
if (outboundContext != null) {
outboundContext.setParent(null);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageChannelSecurityContext.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageChannelSecurityContext.java
index a2f93f3..3401166 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageChannelSecurityContext.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageChannelSecurityContext.java
@@ -48,7 +48,7 @@ public class MessageChannelSecurityContext extends BaseContext {
*
* @param flag The confidentialityActive to set.
*/
- public void setConfidentialityActive(boolean flag) {
+ public void setConfidentialityActive(final boolean flag) {
confidentialityActive = flag;
}
@@ -66,7 +66,7 @@ public class MessageChannelSecurityContext extends BaseContext {
*
* @param flag The integrityActive to set.
*/
- public void setIntegrityActive(boolean flag) {
+ public void setIntegrityActive(final boolean flag) {
integrityActive = flag;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageContext.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageContext.java
index c4dc178..c13f49b 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageContext.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/context/MessageContext.java
@@ -50,7 +50,7 @@ public class MessageContext<MessageType> extends BaseContext {
*
* @param message the message
*/
- public void setMessage(MessageType message) {
+ public void setMessage(final MessageType message) {
msg = message;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/AbstractMessageDecoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/AbstractMessageDecoder.java
index 60f8e7f..325eb51 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/AbstractMessageDecoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/AbstractMessageDecoder.java
@@ -45,7 +45,7 @@ public abstract class AbstractMessageDecoder<MessageType> extends AbstractInitia
*
* @param context the message context
*/
- protected void setMessageContext(MessageContext<MessageType> context) {
+ protected void setMessageContext(final MessageContext<MessageType> context) {
messageContext = context;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
index c551eea..074ce42 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/httpclient/BaseHttpClientResponseXMLMessageDecoder.java
@@ -120,7 +120,7 @@ public abstract class BaseHttpClientResponseXMLMessageDecoder<MessageType extend
try {
Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
}
}
@@ -144,14 +144,14 @@ public abstract class BaseHttpClientResponseXMLMessageDecoder<MessageType extend
*
* @throws MessageDecodingException thrown if there is a problem deserializing and unmarshalling the message
*/
- protected XMLObject unmarshallMessage(InputStream messageStream) throws MessageDecodingException {
+ protected XMLObject unmarshallMessage(final InputStream messageStream) throws MessageDecodingException {
try {
XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
return message;
- } catch (XMLParserException e) {
+ } catch (final XMLParserException e) {
log.error("Error unmarshalling message from input stream", e);
throw new MessageDecodingException("Error unmarshalling message from input stream", e);
- } catch (UnmarshallingException e) {
+ } catch (final UnmarshallingException e) {
log.error("Error unmarshalling message from input stream", e);
throw new MessageDecodingException("Error unmarshalling message from input stream", e);
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
index acb045e..f4c83ce 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/decoder/servlet/BaseHttpServletRequestXMLMessageDecoder.java
@@ -125,7 +125,7 @@ public abstract class BaseHttpServletRequestXMLMessageDecoder<MessageType extend
try {
Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
}
}
@@ -149,14 +149,14 @@ public abstract class BaseHttpServletRequestXMLMessageDecoder<MessageType extend
*
* @throws MessageDecodingException thrown if there is a problem deserializing and unmarshalling the message
*/
- protected XMLObject unmarshallMessage(InputStream messageStream) throws MessageDecodingException {
+ protected XMLObject unmarshallMessage(final InputStream messageStream) throws MessageDecodingException {
try {
XMLObject message = XMLObjectSupport.unmarshallFromInputStream(getParserPool(), messageStream);
return message;
- } catch (XMLParserException e) {
+ } catch (final XMLParserException e) {
log.error("Error unmarshalling message from input stream", e);
throw new MessageDecodingException("Error unmarshalling message from input stream", e);
- } catch (UnmarshallingException e) {
+ } catch (final UnmarshallingException e) {
log.error("Error unmarshalling message from input stream", e);
throw new MessageDecodingException("Error unmarshalling message from input stream", e);
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/AbstractMessageEncoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/AbstractMessageEncoder.java
index e13d290..40554cb 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/AbstractMessageEncoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/AbstractMessageEncoder.java
@@ -37,7 +37,7 @@ public abstract class AbstractMessageEncoder<MessageType> extends AbstractInitia
/** {@inheritDoc} */
@Override
- public synchronized void setMessageContext(MessageContext<MessageType> context) {
+ public synchronized void setMessageContext(final MessageContext<MessageType> context) {
ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
ComponentSupport.ifDestroyedThrowDestroyedComponentException(this);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
index 73d1b41..7d08b6f 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/httpclient/BaseHttpClientRequestXMLMessageEncoder.java
@@ -68,7 +68,7 @@ public abstract class BaseHttpClientRequestXMLMessageEncoder<MessageType extends
try {
Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
}
}
@@ -92,12 +92,12 @@ public abstract class BaseHttpClientRequestXMLMessageEncoder<MessageType extends
*
* @throws MessageEncodingException thrown if the give message can not be marshalled into its DOM representation
*/
- protected Element marshallMessage(XMLObject message) throws MessageEncodingException {
+ protected Element marshallMessage(final XMLObject message) throws MessageEncodingException {
log.debug("Marshalling message");
try {
return XMLObjectSupport.marshall(message);
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Error marshalling message", e);
throw new MessageEncodingException("Error marshalling message", e);
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
index 68450da..4e5b14b 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/encoder/servlet/BaseHttpServletResponseXMLMessageEncoder.java
@@ -68,7 +68,7 @@ public abstract class BaseHttpServletResponseXMLMessageEncoder<MessageType exten
try {
Element dom = XMLObjectSupport.marshall(message);
protocolMessageLog.debug("\n" + SerializeSupport.prettyPrintXML(dom));
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Unable to marshall message for logging purposes", e);
}
}
@@ -92,12 +92,12 @@ public abstract class BaseHttpServletResponseXMLMessageEncoder<MessageType exten
*
* @throws MessageEncodingException thrown if the give message can not be marshalled into its DOM representation
*/
- protected Element marshallMessage(XMLObject message) throws MessageEncodingException {
+ protected Element marshallMessage(final XMLObject message) throws MessageEncodingException {
log.debug("Marshalling message");
try {
return XMLObjectSupport.marshall(message);
- } catch (MarshallingException e) {
+ } catch (final MarshallingException e) {
log.error("Error marshalling message", e);
throw new MessageEncodingException("Error marshalling message", e);
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/handler/AbstractMessageHandler.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/handler/AbstractMessageHandler.java
index 08162fc..cadf68c 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/handler/AbstractMessageHandler.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/handler/AbstractMessageHandler.java
@@ -93,20 +93,20 @@ public abstract class AbstractMessageHandler<MessageType> extends AbstractInitia
if (doPreInvoke(messageContext)) {
try {
doInvoke(messageContext);
- } catch (MessageHandlerException e) {
+ } catch (final MessageHandlerException e) {
try {
doPostInvoke(messageContext, e);
- } catch (Throwable t) {
+ } catch (final Throwable t) {
log.warn("{} Unchecked exception/error thrown by doPostInvoke, "
+ "superseding a MessageHandlerException ", getLogPrefix(), e);
t.addSuppressed(e);
throw t;
}
throw e;
- } catch (Throwable t) {
+ } catch (final Throwable t) {
try {
doPostInvoke(messageContext);
- } catch (Throwable t2) {
+ } catch (final Throwable t2) {
log.warn("{} Unchecked exception/error thrown by doPostInvoke, "
+ "superseding an unchecked exception/error ", getLogPrefix(), t);
t2.addSuppressed(t);
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/BasicMessagePipeline.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/BasicMessagePipeline.java
index 6096f76..af69975 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/BasicMessagePipeline.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/BasicMessagePipeline.java
@@ -115,7 +115,7 @@ public class BasicMessagePipeline<InboundMessageType, OutboundMessageType>
*
* @param handler the new handler
*/
- public void setOutboundTransportHandler(MessageHandler<OutboundMessageType> handler) {
+ public void setOutboundTransportHandler(final MessageHandler<OutboundMessageType> handler) {
outboundTransportHandler = handler;
}
@@ -129,7 +129,7 @@ public class BasicMessagePipeline<InboundMessageType, OutboundMessageType>
*
* @param handler the new handler
*/
- public void setInboundHandler(MessageHandler<InboundMessageType> handler) {
+ public void setInboundHandler(final MessageHandler<InboundMessageType> handler) {
inboundHandler = handler;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/StaticPipelineNameStrategy.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/StaticPipelineNameStrategy.java
index 11c10ad..c41fda8 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/StaticPipelineNameStrategy.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/StaticPipelineNameStrategy.java
@@ -43,7 +43,7 @@ public class StaticPipelineNameStrategy implements Function<InOutOperationContex
}
/** {@inheritDoc} */
- @Nullable public String apply(@Nullable InOutOperationContext<?, ?> input) {
+ @Nullable public String apply(@Nullable final InOutOperationContext<?, ?> input) {
return pipelineName;
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/httpclient/BasicHttpClientMessagePipeline.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/httpclient/BasicHttpClientMessagePipeline.java
index 8c46a39..a39b559 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/httpclient/BasicHttpClientMessagePipeline.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/httpclient/BasicHttpClientMessagePipeline.java
@@ -52,7 +52,7 @@ public class BasicHttpClientMessagePipeline<InboundMessageType, OutboundMessageT
}
/** {@inheritDoc} */
- protected void setEncoder(MessageEncoder<OutboundMessageType> encoder) {
+ protected void setEncoder(final MessageEncoder<OutboundMessageType> encoder) {
if (!(encoder instanceof HttpClientRequestMessageEncoder)) {
throw new IllegalArgumentException("HttpClientRequestMessageEncoder is required");
}
@@ -65,7 +65,7 @@ public class BasicHttpClientMessagePipeline<InboundMessageType, OutboundMessageT
}
/** {@inheritDoc} */
- protected void setDecoder(MessageDecoder<InboundMessageType> decoder) {
+ protected void setDecoder(final MessageDecoder<InboundMessageType> decoder) {
if (!(decoder instanceof HttpClientResponseMessageDecoder)) {
throw new IllegalArgumentException("HttpClientResponseMessageDecoder is required");
}
diff --git a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/servlet/BasicHttpServletMessagePipeline.java b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/servlet/BasicHttpServletMessagePipeline.java
index 42435a9..a9efb94 100644
--- a/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/servlet/BasicHttpServletMessagePipeline.java
+++ b/opensaml-messaging-api/src/main/java/org/opensaml/messaging/pipeline/servlet/BasicHttpServletMessagePipeline.java
@@ -52,7 +52,7 @@ public class BasicHttpServletMessagePipeline<InboundMessageType, OutboundMessage
}
/** {@inheritDoc} */
- protected void setEncoder(MessageEncoder<OutboundMessageType> encoder) {
+ protected void setEncoder(final MessageEncoder<OutboundMessageType> encoder) {
if (!(encoder instanceof HttpServletResponseMessageEncoder)) {
throw new IllegalArgumentException("HttpServletResponseMessageEncoder is required");
}
@@ -65,7 +65,7 @@ public class BasicHttpServletMessagePipeline<InboundMessageType, OutboundMessage
}
/** {@inheritDoc} */
- protected void setDecoder(MessageDecoder<InboundMessageType> decoder) {
+ protected void setDecoder(final MessageDecoder<InboundMessageType> decoder) {
if (!(decoder instanceof HttpServletRequestMessageDecoder)) {
throw new IllegalArgumentException("HttpServletRequestMessageDecoder is required");
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
More information about the commits
mailing list